[AMBARI-22632] Fix misuses of os.path.dirname(path)

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Akira Ajisaka
• Created: 12/Dec/17 08:14
• Updated: 12/Dec/17 16:33

Description

There are some misuses of os.path.dirname(path) in Ambari code base. For example, the following code wrongly sets the permission of /ats/done to 0755 when params.entity_groupfs_store_dir is /ats/done/ (with trailing /).

yarn.py

      parent_path = os.path.dirname(params.entity_groupfs_store_dir)
      params.HdfsResource(parent_path,
                          type="directory",
                          change_permissions_for_parents=True,
                          owner=params.yarn_user,
                          group=params.user_group,
                          mode=0755
                          )

This is because os.path.dirname(path) does not return the parent directory if the path ends with '/'.

$ python
>>> import os
>>> os.path.dirname('/ats/done/')
'/ats/done'

Sub-Tasks

• Fix misuses of os.path.dirname(path) in yarn.py: Resolved