Details
-
Improvement
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
Description
There's a few places in our code which could benefit from additional validation of arguments and configuration by using the built-in Guava Predicates. This makes some checks that we're doing a bit more readable, and enables us to do more expressive validation checks.
Specifically, I see room for improvement in our PropertyType validators (which currently do very limited regex validation) and, to a lesser degree, o.a.a.core.util.Validator.
I intend to replace these with proper Predicates to determine their validity.