[ACCUMULO-3425] Clean up Thrift client/server factory classes

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: rpc
• Assignee: Josh Elser
• Reporter: Josh Elser
• Created: 16/Dec/14 20:23
• Updated: 18/Dec/14 02:18
• Resolved: 17/Dec/14 00:46

Description

ThriftUtil (in core) and TServerUtils (in server-base) could both stand to use a general cleanup (as I found in working on ACCUMULO-2815).

• Whitespace
• Ensure client/server logic separation (ThriftUtil/TServerUtils, respectively)
• Any Javadoc
• Switch over to slf4j loggers for better logging without excessive string creation concerns