Bug 48129 - [PATCH] Fix build with OpenSSL 1.0.0-beta3
Summary: [PATCH] Fix build with OpenSSL 1.0.0-beta3
Status: RESOLVED FIXED
Alias: None
Product: Tomcat Native
Classification: Unclassified
Component: Library (show other bugs)
Version: unspecified
Hardware: PC Linux
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-04 10:06 UTC by Ville Skyttä
Modified: 2010-01-05 01:51 UTC (History)
1 user (show)


Attachments
Fix build with OpenSSL 1.0.0-beta3 (1.88 KB, patch)
2009-11-04 10:06 UTC, Ville Skyttä 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ville Skyttä 2009-11-04 10:06:32 UTC 
Created attachment 24472 [details]
Fix build with OpenSSL 1.0.0-beta3

The attached patch is needed to build tomcat-native with OpenSSL 1.0.0-beta3. 
In addition to 1.0.0-beta3, I have successfully build-tested it with OpenSSL
0.9.8k (Fedora 11) and 0.9.8e (CentOS 5.4).

Kudos for the patch belong to Tomas Mraz (tmraz at redhat.com) who applied it
in the Fedora tomcat-native packages, I'm just forwarding it here after
noticing that it is still needed with tomcat-native 1.1.17.

The build error with OpenSSL 1.0.0-beta3 without this patch is:

src/sslutils.c: In function 'SSL_CTX_use_certificate_chain':
src/sslutils.c:427: error: 'STACK' undeclared (first use in this function)
src/sslutils.c:427: error: (Each undeclared identifier is reported only once
src/sslutils.c:427: error: for each function it appears in.)
src/sslutils.c:427: error: 'extra_certs' undeclared (first use in this
function)
Comment 1 Rainer Jung 2010-01-04 10:15:19 UTC 
Thanks for the patch

It has been applied to tcnative trunk in r895731 plus r890720 and to tcnative branch 1.1.x in r895733 plus r890719.

The patch will be part of tcnative 1.1.19.
Comment 2 Ville Skyttä 2010-01-04 11:32:12 UTC 
Thank you for applying the patch, but it seems I have been kind of miscredited for it - its original author is Tomas Mraz (tmraz at redhat.com) - see my initial comment here.

Reopening, requesting correction of fix authorship in change log.
Comment 3 Rainer Jung 2010-01-05 01:51:56 UTC 
Fixed patch author in changelog and svn log.
Sorry about missing that initially.