I was using BCEL for a school project over the last few months and noticed that the Javadoc needs improvement in some areas. Having free time on my hands after the end of the project (and semester), I'm interested in doing a (likely large or multi-part) patch to flesh it out. Two questions: 1. Is anyone else working on this currently? 2. Which source code base should I work on? (My guess is http://svn.apache.org/repos/asf/jakarta/bcel/trunk/src/main) I'll be starting sometime in the next week. Family is visiting until Monday, so I'm not entirely sure when I'm free right now. Thanks. -Charlie
Charlie, your help would surely be appreciated. Trunk would be the right place for it. Cheers, Torsten
TYPE_NAMES, CLASS_TYPE_NAMES, and SHORT_TYPE_NAMES (in org.apache.bcel.Constants) were missing entries for T_ADDRESS. Entries "address", ILLEGAL_TYPE, and ILLEGAL_TYPE (respectively) have been added to my copy. I should have a patch for Constants.java momentarily, I'm around 98% through the file. -Charlie
Created attachment 20209 [details] SVN diff of trunk overhauling the javadoc comments. Ran into one more problem in Constants.java. There was a broken TODO (misspelled as TOFO) on ATTRIBUTE_NAMES, saying "FIXXXXX". The array looks fine to me, though using ATTR_UNKNOWN could be a problem, as it's got value -1. I fixed the TODO, added a warning to the Javadoc, and left a similar explanation to this one in the code. Anyway, here's the svn diff of trunk for Constants.java.
Waiting for feedback before I go onwards. Just to make sure I'm on the right track.
thanks ....applied! sorry for the delay. please cross check