Bug 41548 - Properly parse StackMapTable attributes in Java 6 classfiles
Summary: Properly parse StackMapTable attributes in Java 6 classfiles
Status: RESOLVED FIXED
Alias: None
Product: BCEL - Now in Jira
Classification: Unclassified
Component: Main (show other bugs)
Version: unspecified
Hardware: All All
: P2 enhancement
Target Milestone: ---
Assignee: issues@commons.apache.org
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-05 17:26 UTC by Michael Martin
Modified: 2008-02-02 11:18 UTC (History)
0 users


Attachments
Simple patch to add StackMapTable parsing (9.24 KB, patch)
2007-02-05 17:29 UTC, Michael Martin 		Details | Diff
correct patch (20.45 KB, patch)
2007-02-05 17:35 UTC, Michael Martin 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Martin 2007-02-05 17:26:47 UTC 
Java 6 includes a "StackMapTable" type that is used for its new split
verification scheme.  This means many Code attributes will have StackMapTable
attributes attached.  This format is similar but not quite identical to the
already implemented StackMap.

I have developed a patch that adds the necessary functionality to the classfile
parser (mostly by copy-pasting code from StackMap and StackMapEntry), and will
attach it shortly
Comment 1 Michael Martin 2007-02-05 17:29:57 UTC 
Created attachment 19524 [details]
Simple patch to add StackMapTable parsing

This patch is largely directly derived from StackMap and StackMapEntry; it does
not properly update Javadocs yet because I am unsure if this is actually the
approach you want to take.  I can perform the documentation updates on request.
Comment 2 Michael Martin 2007-02-05 17:35:41 UTC 
Created attachment 19525 [details]
correct patch

The previous patch is an earlier attempt that rewrote the StackMap parser
itself, and does not retain compatibility.  This is the correct patch. 
Apologies.
Comment 3 Torsten Curdt 2007-03-10 07:31:53 UTC 
More than happy to apply this patch ...but could you also make sure there are
some test for it? Plus it currently breaks compilation for the tests.
Comment 4 Torsten Curdt 2008-02-02 11:18:49 UTC 
applied ...some tests would still be great ;)