Bug 36164 - Empty merge expression gives internal server error
Summary: Empty merge expression gives internal server error
Status: NEW
Alias: None
Product: Slide
Classification: Unclassified
Component: Search (show other bugs)
Version: 2.1
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: Slide Developer List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-12 18:29 UTC by Max Pfingsthorn
Modified: 2005-08-12 11:21 UTC (History)
0 users


Attachments
patch to fix for 2.1 release branch (597 bytes, patch)
2005-08-12 19:21 UTC, Max Pfingsthorn 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Pfingsthorn 2005-08-12 18:29:05 UTC 
If a dasl query just consists of an empty merge expression, like <d:or/>, slide
will respond with 500 because the expression generated will be null and cause a
NPE in the BasicQueryImpl, line 134.
This is a very easy fix, for both slide 2.1 and trunk:
On line 208 (trunk) or 206 (2.1) of BasicExpressionCompiler, if the
mergeExpression is null, then throw a BadQueryException("OR and AND cannot be
empty!").
Comment 1 Max Pfingsthorn 2005-08-12 19:21:00 UTC 
Created attachment 16021 [details]
patch to fix for 2.1 release branch

since patches are always better...