Bug 35835 - Submitting changes through admin app corrupts the HTTPS connector definition in server.xml
Summary: Submitting changes through admin app corrupts the HTTPS connector definition ...
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 5
Classification: Unclassified
Component: Webapps:Administration (show other bugs)
Version: 5.5.9
Hardware: Other other
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-23 03:12 UTC by smalladi
Modified: 2006-10-01 21:33 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description smalladi 2005-07-23 03:12:50 UTC
I'm using tomcat 5.5.9 version and when I use the admin app to make any changes
to the server.xml file (or evn if I just save, without making any changes), the
HTTPS connector definition (if there is one defined) in server.xml gets
corrupted. Basically the the attribute "sslProtocol=TLS"" is omitted when saving it.
As a result, https connection doesn't work. If I add that attribute manually
after  I save the changes through the admin app, then https connection works.

We noticed a similar problem on tomcat 5.0.28 as well, and I posted a question
about this on the tomcat mailing lists last month. In tomcat 5.0.28, the issue
was slightly different that when you save changes through the admin webapp, the
following duplicate attributes to the HTTPS connector were being added. If we
remove those entries manually, then the connector seem to come up fine.
Comment 1 Yoav Shapira 2005-07-27 02:11:17 UTC
For the storeconfig module, this was fixed in 5.5.10: see
http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-catalina/modules/storeconfig/src/share/org/apache/catalina/storeconfig/ConnectorStoreAppender.java?rev=1.3&view=log.
 Can you please test 5.5.10 and let us know?
Comment 2 Yoav Shapira 2005-09-01 20:48:46 UTC
Well, when you get a chance to test, please let us know.
Comment 3 smalladi 2005-09-02 02:27:44 UTC
Yes, I'd like to test it out. But where I can get 5.5.10 from ? I see 5.5.9 and
5.5.11-alpha from the download page. Would you like me to try 5.5.11-alpha ?
thanks (and sorry for the delay in responding to this)
Comment 4 smalladi 2005-09-17 03:28:51 UTC
I verified that this works in 5.5.11-alpha. Any idea whether/when the fix will
be ported to 5.0.x (currently 5.0.30) ? If the fix is to the admin webapp only,
then,
can I just take the admin webapp from 5.5.11 and then try it under 5.0.x ? thanks.
Comment 5 yonmoon 2005-09-29 13:42:45 UTC
This is a bug(perhaps) for EXE installed verion of tomcat5.5.12,the ZIP 
version is correct.
with EXE installed version,if i you edit config file(server.xml) in admin app
the http 8080 connector changes to:
<connector type="HTTPS" sheme="http"...
>
Comment 6 Mark Thomas 2006-10-01 21:33:13 UTC
Closing this as fixed since the OP tested it and reported that the issue was
fixed in 5.5.11.

It is very unlikely that this will be ported to 5.0.x since development has all
but stopped on that branch.

Comment 5 is not directly related to the original issue. The .exe code and .zip
code are identical so the described behaviour is very unexpected. If this is
still an issue, please open a new bug report.