Bug 30615 - Installing Tomcat as a Windows Service fails to recognize non-standard service name
Summary: Installing Tomcat as a Windows Service fails to recognize non-standard servic...
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 5
Classification: Unclassified
Component: Unknown (show other bugs)
Version: 5.0.24
Hardware: Other All
: P3 major (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-12 13:08 UTC by Sean McRae
Modified: 2005-03-20 17:06 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean McRae 2004-08-12 13:08:03 UTC 
Usinng service.bat to install Tomcat 5 as a Windows service does not respect 
the service name passed from the command line. Error appears to be in line 64 
of service.bat:

ERRANT:  set PR_DISPLAYNAME=Apache Tomcat

CORRECT: set PR_DISPLAYNAME=%SERVICE_NAME%

Optionally there could be hard coded values in there like this: (our solution)

OPTIONAL: set PR_DISPLAYNAME=Apache Tomcat %SERVICE_NAME%
Comment 1 Mladen Turk 2004-08-12 13:45:24 UTC 
Well, It's not a major bug :)

Anyhow the patched version is in the CVS.
It sets the display name to a different value ony if the service name
has been provided at the command line.
Comment 2 Sean McRae 2004-08-12 13:49:59 UTC 
Cool, thanks. Only marked it as major since the install fails if you attempt to 
install the service multiple times (like we do). The script runs and fails but 
still says the service was installed. Perhaps there should be a check for the 
return value from the executable to indicate success/failure in the file?