Bug 28366 - The example for request filters is wrong
Summary: The example for request filters is wrong
Status: RESOLVED DUPLICATE of bug 16507
Alias: None
Product: Tomcat 4
Classification: Unclassified
Component: Webapps:Documentation (show other bugs)
Version: Nightly Build
Hardware: All All
: P3 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL: http://jakarta.apache.org/tomcat/tomc...
Keywords:
Depends on:
Blocks:
 
Reported: 2004-04-13 20:36 UTC by Steven Citron-Pousty
Modified: 2004-11-16 19:05 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Steven Citron-Pousty 2004-04-13 20:36:15 UTC
The documentation contains examples for the proper syntax for a request filter
but the syntax is wrong. The doco says the filter uses the regex library but the
example does not use regex syntax.

Here is what the example is:

<Valve className="org.apache.catalina.valves.RemoteHostValve"
         allow="*.mycompany.com,www.yourcompany.com"/>
<Valve className="org.apache.catalina.valves.RemoteAddrValve"
         deny="192.168.1.*"/>

Should be:

<Valve className="org.apache.catalina.valves.RemoteHostValve"
         allow=".*mycompany\.com,www\.yourcompany\.com"/>
  <Valve className="org.apache.catalina.valves.RemoteAddrValve"
         deny="192\.168\.1\..*"/>

Thanks,
Steve
Comment 1 Mark Thomas 2004-07-14 20:55:50 UTC
The documentation has been updated in CVS.

*** This bug has been marked as a duplicate of 16507 ***