| Summary: | Empty merge expression gives internal server error | ||
|---|---|---|---|
| Product: | Slide | Reporter: | Max Pfingsthorn <m.pfingsthorn> |
| Component: | Search | Assignee: | Slide Developer List <slide-dev> |
| Status: | NEW --- | ||
| Severity: | normal | ||
| Priority: | P2 | ||
| Version: | 2.1 | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Attachments: | patch to fix for 2.1 release branch | ||
Created attachment 16021 [details]
patch to fix for 2.1 release branch
since patches are always better...
|
If a dasl query just consists of an empty merge expression, like <d:or/>, slide will respond with 500 because the expression generated will be null and cause a NPE in the BasicQueryImpl, line 134. This is a very easy fix, for both slide 2.1 and trunk: On line 208 (trunk) or 206 (2.1) of BasicExpressionCompiler, if the mergeExpression is null, then throw a BadQueryException("OR and AND cannot be empty!").