Bug 5040 - [review] 'meta test has dependency with zero score' should ignore rules in other scoresets
Summary: [review] 'meta test has dependency with zero score' should ignore rules in ot...
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: Libraries (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P5 minor
Target Milestone: 3.1.6
Assignee: SpamAssassin Developer Mailing List
URL:
Whiteboard: ready to commit
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-10 09:53 UTC by Justin Mason
Modified: 2006-10-03 16:39 UTC (History)
0 users


Attachment Type Modified Status Actions Submitter/CLA Status
fix patch None Justin Mason [HasCLA]
fix r2 patch None Justin Mason [HasCLA]
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Mason 2006-08-10 09:53:31 UTC 
running a scan in scoreset 0, I see:

[18254] info: rules: meta test T_SURBL_MULTI3 has dependency 'URIBL_JP_SURBL'
with a zero score
[18254] info: rules: meta test T_SURBL_MULTI3 has dependency 'URIBL_SC_SURBL'
with a zero score
[18254] info: rules: meta test T_SURBL_MULTI3 has dependency 'URIBL_AB_SURBL'
with a zero score
[18254] info: rules: meta test T_SURBL_MULTI3 has dependency 'URIBL_OB_SURBL'
with a zero score
[18254] info: rules: meta test T_SURBL_MULTI3 has dependency 'URIBL_WS_SURBL'
with a zero score


in fact, those rules have a non-zero score in the net scoresets; the only reason
they have a zero score here, is because a non-net scoreset is active.  this
shouldn't be warned about.
Comment 1 Daryl C. W. O'Shea 2006-08-10 10:16:33 UTC 
Perhaps these meta rules should just have tflags net entries (I had just copied
what Matt sent me).
Comment 2 Theo Van Dinter 2006-08-10 14:09:24 UTC 
> in fact, those rules have a non-zero score in the net scoresets; the only reason
> they have a zero score here, is because a non-net scoreset is active.  this
> shouldn't be warned about.

I would suggest we close this as a dupe of bug 4347 and continue the discussion
there.  It's a continuing issue, and I already brought this up as something to
think about in comment 38.
Comment 3 Justin Mason 2006-09-04 17:20:04 UTC 
Created attachment 3683 [details]
fix

I didn't want to get lost in the confusion at bug 4347, so I just fixed this. 
added to trunk in r440126.
Comment 4 Justin Mason 2006-09-04 17:22:11 UTC 
aiming at 3.1.x
Comment 5 Justin Mason 2006-09-04 17:23:00 UTC 
Created attachment 3684 [details]
fix r2

that didn't apply cleanly to 3.1. this does...
Comment 6 Daryl C. W. O'Shea 2006-09-29 10:36:54 UTC 
+1
Comment 7 Sidney Markowitz 2006-10-03 15:11:29 UTC 
+1
Comment 8 Daryl C. W. O'Shea 2006-10-03 16:39:25 UTC 
[dos@FC5-VPC 3.1]$ svn ci -m "bug 5040: if in no-net scoreset, don't warn about
net rules being zero-score dependencies of meta rules"
Sending        lib/Mail/SpamAssassin/PerMsgStatus.pm
Transmitting file data .
Committed revision 452676.