Bug 4515 - content preview omits first paragraph when no Subject:
Summary: content preview omits first paragraph when no Subject:
Status: RESOLVED FIXED
Alias: None
Product: Spamassassin
Classification: Unclassified
Component: spamassassin (show other bugs)
Version: SVN Trunk (Latest Devel Version)
Hardware: Other other
: P4 normal
Target Milestone: 3.2.0
Assignee: John Gardiner Myers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-03 15:11 UTC by John Gardiner Myers
Modified: 2005-11-07 11:55 UTC (History)
1 user (show)


Attachment Type Modified Status Actions Submitter/CLA Status
work in progress patch None John Gardiner Myers [HasCLA]
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Gardiner Myers 2005-08-03 15:11:55 UTC 
When run on a message without a Subject: header, the content preview incorrectly
contains the second paragraph, not the first.

Similarly, code inspection suggests that if a Subject header is longer than
MAX_BODY_LINE_LENGTH, the content preview will incorrectly contain text taken
from wherever the subject is wrapped.

There needs to be a clear, deterministic way to obtain the decoded body text
absent the subject.  The same mehtod should also be work for the visible body text.
Comment 1 John Gardiner Myers 2005-08-03 15:19:21 UTC 
Created attachment 3050 [details]
work in progress

This patch fixes the issue with missing subjects, but not the issue with long
subjects.  Either we would need to risk not splitting long subject lines or we
would need to add an argument to the functions specifying whether or not they
should include the subject.
Comment 2 John Gardiner Myers 2005-10-14 16:25:31 UTC 
Taking.
Comment 3 John Gardiner Myers 2005-11-07 20:55:11 UTC 
Committed revision 331590.

Doesn't deal with the case where the Subject header is longer than
MAX_BODY_LINE_LENGTH.  The alternatives aren't particularly attractive.