[VELOCITY-551] IncludeNotFound event handler not including the "notfound" page

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5
• Fix Version/s: 1.6
• Component/s: Engine
• Environment: Linux (Fedora Core 5) / OSX 10.4.9; Java 6; Tomcat 6.0.10; Struts2
• Assignee: Unassigned
• Reporter: Michiel Toneman
• Created: 31/May/07 16:01
• Updated: 06/Jun/07 08:39
• Resolved: 05/Jun/07 03:52

Description

The IncludeNotFound event handler claims in the log "Can't find include not found
page: " even though the "notfound" page exists.

I've tracked this in the source:
------------------------------------------------
boolean exists = (rs.getLoaderNameForResource(includeResourcePath) != null);
if (!exists)
{
if (rs.getLoaderNameForResource(notfound) == null)

{ return notfound; }

else

{ /** * can't find not found, so display nothing */ rs.getLog().error("Can't find include not found page: " + notfound); return null; }

}
else
return includeResourcePath;
---------------------------------------------------

I think the condition:

if (rs.getLoaderNameForResource(notfound) == null)

should read:

if (rs.getLoaderNameForResource(notfound) != null)

Changing this fixed the problem for me.