Details
-
Bug
-
Status: Closed
-
Major
-
Resolution: Fixed
-
1.5
-
None
-
None
Description
ASTReference.java has some null check logic that does, summarized:
if (value == null || value.toString() == null) {
...
} else {
... output value.toString();
}
Note value.toString() being called twice.
For strings and other primitives, this may not be a big deal, but I'm happily using Click, which puts full-fledged components into the velocity context that you render with "$componentName". Very slick. But now calling toString() multiple times isn't all that cool, both from perf and logic standpoints.
I've got a patch if I can figure out how to upload it.