[QPID-2402] qpid::messaging.Message::setTTL() unit ambiguity can cause unexpectected behavior

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.6
• Component/s: C++ Broker, C++ Client
• Assignee: Gordon Sim
• Reporter: Kerry Bonin
• Created: 11/Feb/10 16:44
• Updated: 29/Jul/13 18:53
• Resolved: 03/Mar/10 17:48

Description

qpid::messaging.Message::setTTL( boost::uint64_t ttl ) - does not declare its units.

The currently exposed time types are AbsTime and Duration, which seems to imply they should be used for encapsulating time.

When a Duration object is passed to setTTL, the inline operator int64_t() returns the member variable nanoseconds.

When this value is propagated to the broker, it is interpreted around /cpp/src/qpid/broker/Message # 353 to be in millisecond units.

I would recommend:

• document Message.setTTL units clearly - pick ms or ns
• if ms, then overload setTTL to take a Duration object so we can use without error by converting in setTTL
• if ns, then somewhere downstream (OutgoingMessage#351 ?) the ns needs to get converted to ms

Issue Links

• is part of: QPID-2406 Consistent approach to durations in qpid::messaging api