[GERONIMO-3420] Remote deploy of an EAR without an application.xml plan fails

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.0, 2.0.x, 2.1
• Fix Version/s: 2.0.2, 2.1
• Component/s: deployment
• Security Level: public (Regular issues)

Environment

Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface

• Regression: Regression
• Assignee: Donald Woods
• Reporter: Donald Woods
• Created: 16/Aug/07 21:26
• Updated: 25/Sep/07 18:23
• Resolved: 21/Aug/07 04:29

Description

Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -

private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
String specDD;
ApplicationType application = null;
if (earFile != null) {
try

{ URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml"); specDD = DeploymentUtil.readAll(applicationXmlUrl); //we found something called application.xml in the right place, if we can't parse it it's an error XmlObject xmlObject = XmlBeansUtil.parse(specDD); application = convertToApplicationSchema(xmlObject).getApplication(); }

catch (XmlException e)

{ throw new DeploymentException("Could not parse application.xml", e); }

catch (Exception e) {
//ee5 spec allows optional application.xml, continue with application == null
if (!earFile.getName().endsWith(".ear"))

{ return null; }

//TODO return application.xml that we can make metadata complete?
}
}