Issue 99918 - Error in proposed filename if containing spaces
Summary: Error in proposed filename if containing spaces
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: OOO310m4
Hardware: PC Windows Vista
: P3 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: Olaf Felka
QA Contact: issues@framework
URL:
Keywords: regression
Depends on:
Blocks: 95768
  Show dependency tree
 
Reported: 2009-03-05 10:53 UTC by vitriol
Modified: 2009-03-26 15:53 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description vitriol 2009-03-05 10:53:13 UTC
OOO310m4 on Win Vista.
Steps to reproduce:
- Create a new document (i.e. Writer)
- Save the document as filename containing spaces (i.e. "test test test.odt)
- Reopen the document
- Select "Save As..."
- ERROR: the proposed name contains the sequence %20 instead of spaces (i.e.
"test%20test%20test.odt")
Comment 1 tommy27 2009-03-05 12:57:24 UTC
if this issue is confirmed, it should be regarded as a 3.1 stopper.

just an information: if you say OK to save, do you come with a test%20test
%20test.odt file or the file is saved correctly?

 
Comment 2 vitriol 2009-03-05 13:05:23 UTC
The file is saved with the wrong name test%20test%20test.odt
Comment 3 tommy27 2009-03-05 13:17:51 UTC
well, this is clearly a regression...

i hope this can be fixed in OOo 3.0.1

i save a lot of files with spaces in the filename...

all those "%20" in the filename look weird and remind me old O/S days...
Comment 4 vitriol 2009-03-05 13:22:31 UTC
With OOo native dialogs it works fine, as usual...
Comment 5 tommy27 2009-03-05 14:21:15 UTC
i don't understand your last comment

non ho capito il tuo ultimo commento
Comment 6 tommy27 2009-03-05 14:26:20 UTC
i don't understand your last comment

non ho capito il tuo ultimo commento
Comment 7 vitriol 2009-03-05 14:34:10 UTC
The problem affect only the Vista system file dialog. Native OOo dialog (Tools >
Options... > OpenOffice.org > General > Use OpenOffice.org dialogs, works fine.
Comment 8 vitriol 2009-03-05 14:38:33 UTC
Added keyword regression.
Comment 9 carsten.driesner 2009-03-06 11:53:01 UTC
cd: Accepted and starting.
Comment 10 uwe.luebbers 2009-03-06 12:00:25 UTC
set target and reassigned
Comment 11 carsten.driesner 2009-03-06 12:49:38 UTC
cd: Started.
Comment 12 carsten.driesner 2009-03-06 13:47:14 UTC
cd->mav: As discussed the root cause is related to your changes in
sfx2\source\doc\guisaveas.exe. The Vista file dialog is only one which don't
decode the provided name, therefore this problem can only be seen on Vista. From
my point of view the Vista file dialog is the only one which handles the name
correctly. It's not clear that the name is encoded and decoding must be done by
the framework code.

cd->QA: As this issue will be fixed in the platform independent part, ALL
platforms must be tested!
Comment 13 mikhail.voytenko 2009-03-06 15:33:13 UTC
The file name is now provided in decoded state.
Comment 14 mikhail.voytenko 2009-03-09 12:37:13 UTC
mav->of: Please verify the issue. Additionally please test the scenario from
issue 99680. It is affected by the fix.
Comment 15 Olaf Felka 2009-03-11 12:55:26 UTC
of: Fix verified in cws mav48.
Comment 16 Olaf Felka 2009-03-26 15:53:28 UTC
looks good in master ooo310_m7