Issue 97129 - Hidden last slide of presentation shown when go backwards from black finish-screen
Summary: Hidden last slide of presentation shown when go backwards from black finish-s...
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: viewing (show other issues)
Version: OOo 3.0
Hardware: PC All
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: groucho266
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-12-11 09:38 UTC by aksdb
Modified: 2017-05-20 10:35 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: 4.0.0
Developer Difficulty: ---

Attachments
Proposed patch to fix this problem (1.49 KB, patch)
2013-06-15 14:27 UTC, hanya 		no flags Details | Diff
Patch to use current slide index to be back to last shown slide (622 bytes, patch)
2013-06-16 08:33 UTC, hanya 		no flags Details | Diff
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description aksdb 2008-12-11 09:38:34 UTC 
Example: 5 slides, 4 and 5 hidden. In presentation mode it correctly shows 1, 2,
3 and afterwards the black finish-screen. If you go back from there it shows
slide 5, 3, 2, 1, although 5 is supposed to be hidden.

I tested it in OOo3 on Linux and Windows.
Comment 1 wolframgarten 2008-12-11 09:45:12 UTC 
Reproducible. Reassigned.
Comment 2 Rainer Bielefeld 2013-06-15 07:20:04 UTC 
Still Reproducible with server installation of  "AOO 4.0.0-Dev – English UI / German locale [AOO400m2(Build:9701)  -  Rev. 1493305
Rev.1491054  2013-06-14]" on WIN7 Home Premium (64bit)", own separate user profile

You can try with Attachment 80858 [details] for Bug 120159

Additional Info:
---------------
a) This one is not "Trivial", if a presenter wants to keep a slide hidden it is more than bad if his plan becomes frustrated by AOO

b) Competitors:
Respect hidden last slide also in this particular case:
* LibreOffice  4.2.0.0.alpha0+ Build ID: f4a4fee523ff8a6d272eabda2ce9ca96bd3bbbb
TinderBox: Win-x86@6, Branch:master, Time: 2013-06-14_23:53:13

Same Problem:
* Lotus Symphony 3 Release 3.0.1 Revision 20120110.2000

No possibility to hide slides:
* Calligra

c) Relations: "Bug 120159 - Hidden start slide shown in slide show"
Comment 3 hanya 2013-06-15 14:27:52 UTC 
Created attachment 80861 [details]
Proposed patch to fix this problem

When the mode is SHOWWINDOWMODE_END in SlideshowImpl::gotoPreviousSlide method 
defined in sd/source/ui/slideshow/slideshowimpl.cxx, 
previous slide index is calculated with mpSlideController->getSlideIndexCount() - 1.
This way is wrong, getSlideIndexCount method returns size of vector that contains 
slide indexes.

At this time, AnimationSlideController::getCurrentSlideIndex method returns last 
index of the visible page if the show is proceeded without END key.
When I push END key to move to the last slide, the last slide in the slides is 
shown even the page is hidden.
So I introduced new method to get last visible slide from the list of slide indexes.
Comment 4 hanya 2013-06-15 23:02:15 UTC 
Attached patch in Comment 3 is bad. 
Hidden slides should be considered that they are visible once they have shown.
So, getCurrentSlideIndex is the choice in this case.
Comment 5 hanya 2013-06-15 23:02:55 UTC 
Comment on attachment 80861 [details]
Proposed patch to fix this problem

Set obsolete flag to the attached file.
Comment 6 hanya 2013-06-16 08:33:19 UTC 
Created attachment 80869 [details]
Patch to use current slide index to be back to last shown slide

Using AnimationSlideController::getCurrentSlideIndex method to get last slide index.
Comment 7 SVN Robot 2014-01-10 15:30:03 UTC 
"hanya" committed SVN revision 1557152 into trunk:
#i97129# fix hidden slide shown when going back to previous slide from finish...
Comment 8 hanya 2014-01-10 15:30:50 UTC 
Fixed on trunk.
Comment 9 liuping 2014-04-10 02:44:27 UTC 
verified on windows7 on AOO410m15(Build:9761)  -  Rev. 1583666
2014-04-01 13:53:14 (Di, 01 Apr 2014)