Issue 97032 - no .lck file created anymore when connecting to an embedded HSQLDB
Summary: no .lck file created anymore when connecting to an embedded HSQLDB
Status: CLOSED FIXED
Alias: None
Product: Base
Classification: Application
Component: code (show other issues)
Version: DEV300m37
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.1
Assignee: kurt.zenker
QA Contact: issues@dba
URL:
Keywords: regression
Depends on:
Blocks: 95768
  Show dependency tree
 
Reported: 2008-12-08 19:31 UTC by Frank Schönheit
Modified: 2013-07-06 06:55 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Frank Schönheit 2008-12-08 19:31:04 UTC
- open an arbitrary database document with embedded HSQLDB data
- connect to the DB by choosing "Tables" on the left hand side
- look into the file system, into the folder where the database document
  resides
=> there's no <databasefile.odb>.lck file

This lock file is needed in certain scenarios where multiple clients access the
same database documents, to prevent data corruption.
Comment 1 Frank Schönheit 2008-12-08 19:32:03 UTC
This is a regression between DEV300m29 and DEV300m30, thus we should fix it for 3.1.
Comment 2 Frank Schönheit 2008-12-08 19:35:44 UTC
fs->oj: most probably a regression of issue 91920, which upgraded HSQLDB to
1.8.0.10. I suppose the new HSQLDB version has a bug that the access to the lock
file is routed through the file access abstraction layer (i.e. into our
storage), though it is exactly the one file which *must not* be accessed via
this layer, but via Java's normal file API.
Comment 3 ocke.janssen 2009-01-21 12:14:17 UTC
Fixed in cws dba31h.
new patch for hsqldb for the src/org/hsqldb/perists/HsqlDatabaseProperties.java
Comment 4 Frank Schönheit 2009-01-23 20:39:08 UTC
fs->msc: please verify in CWS dba31h
Comment 5 marc.neumann 2009-01-28 10:15:42 UTC
verified in CWS dba31h

find more information about this CWS, like when it is available in the master
builds, in EIS, the Environment Information System:
http://eis.services.openoffice.org/EIS2/cws.ShowCWS?Path=DEV300%2Fdba31h
Comment 6 Frank Schönheit 2009-02-23 20:50:24 UTC
fs->oj: does not seem to be fixed in OOO310.m2. Please investigate.
Comment 7 Frank Schönheit 2009-02-23 20:51:31 UTC
re-opening, since it's not fixed in the milestone where the CWS (dba31h) has
been integrated.
Comment 8 Frank Schönheit 2009-02-23 20:53:45 UTC
Just tested this in my latest installation set of dba31h - there the issue is
fixed. Sigh.
Comment 9 Frank Schönheit 2009-02-23 21:09:55 UTC
fs->oj: forget about the investigation ...

it seems that the complete CWS dba31h (respectively its clone: dba31h_OOO310)
has *not* been integrated into OOO310.m2, though EIS states otherwise.

For details, see my recent mail in releases@openoffice.org (not yet in the
archive, so I cannot link) titled "OOo 3.1 - stop the release!".
Comment 10 rt 2009-02-24 10:39:25 UTC
CWS dba31h_OOO310 *has* been integrated. See f.e.
 svn log -v -r267835
or
 svn diff -c267835
Could you please provide any details (names of files with missing changes) what
got lost?
Comment 11 Frank Schönheit 2009-02-24 10:51:22 UTC
just poked a little bit with Ause ...

indeed it seems the files are there (also the fixes for other issues), but have
not been built and/or delivered completely.

For instance, the hsqldb.jar (which is to contain the fix for this issue here)
in hsqldb/wntmsci12.pro/misc/build/hsqldb/lib on "O:" is newer (and bigger) than
the delivered version.
Comment 12 Frank Schönheit 2009-02-24 10:52:22 UTC
fs->kz: Can you please ensure that all modules which have been touched in m2 are
built and delivered in m3, again? Thanks.
Comment 13 kurt.zenker 2009-02-24 15:52:23 UTC
All modules from dba31h_ooo310 will be build again in m3. So I set this issue to
fixed.
Comment 14 marc.neumann 2009-02-26 13:50:51 UTC
Hi,

This issue is fixed in the OOO310 m3 master.
I close this issue now.

Bye Marc
Comment 15 Andrea Pescetti 2013-07-06 06:55:20 UTC
For the record, the fix is now included in the fix for bug 121754.