Apache OpenOffice (AOO) Bugzilla – Issue 91949
GCF - Writing Aids dialog adjustment: Remove "Old German Spelling", "Check in all languages", "Do not mark errors"
Last modified: 2013-08-07 14:44:20 UTC
The Writing Aids needs to be changed according to spec. Basically this means to remove three entries.
.
Files changed: - svx/inc/svx/optlingu.hxx - svx/source/options/optlingu.cxx - svx/source/options/optlingu.hrc - svx/source/options/optlingu.src - svx/sdi/svx.sdi (SID_AUTOSPELL_MARKOFF removed) - offapi/com/sun/star/linguistic2/LinguProperties.idl - officecfg/registry/schema/org/openoffice/Office/Linguistic.xcs - linguistic/inc/lngprops.hxx - linguistic/source/lngopt.cxx - svtools/inc/svtools/lingucfg.hxx - svtools/source/config/lingucfg.cxx
Additional files changed: - svx/source/dialog/SpellDialog.cxx - svx/source/dialog/treeopt.cxx - sfx2/inc/sfx2/sfxsids.hrc - sw/inc/unomap.hxx - sw/inc/unoprnms.hxx - sw/inc/viewopt.hxx - sw/sdi/_viewsh.sdi - sw/sdi/annotsh.sdi - sw/sdi/drwtxtsh.sdi - sw/source/core/text/inftxt.cxx - sw/source/core/txtnode/txtedt.cxx - sw/source/core/unocore/unomap.cxx - sw/source/core/unocore/unoprnms.cxx - sw/source/ui/app/docsh2.cxx - sw/source/ui/docvw/postit.cxx - sw/source/ui/shells/annotsh.cxx - sw/source/ui/shells/drwtxtex.cxx - sw/source/ui/shells/drwtxtsh.cxx - sw/source/ui/uiview/pview.cxx - sw/source/ui/uiview/view.cxx - sw/source/ui/uiview/view0.cxx - sw/source/ui/uiview/viewdraw.cxx - sw/source/ui/uiview/viewling.cxx - sw/source/ui/uno/unotxvw.cxx
Additional files changed: - sd/inc/drawdoc.hxx - sd/inc/sdgrffilter.hxx - sd/inc/sdhtmlfilter.hxx - sd/sdi/app.sdi - sd/source/core/drawdoc.cxx - sd/source/filter/grf/sdgrffilter.cxx - sd/source/filter/html/sdhtmlfilter.cxx - sd/source/ui/app/sdmod1.cxx - sd/source/ui/tools/PreviewRenderer.cxx - sd/source/ui/view/Outliner.cxx - sd/source/ui/view/PrintManager.cxx - sd/source/ui/view/sdview.cxx - svx/inc/editstat.hxx - svx/source/editeng/editeng.cxx - svx/source/editeng/editstt2.hxx - svx/source/editeng/impedit3.cxx - svx/source/editeng/impedit4.cxx - svx/source/svdraw/svdotext.cxx
Additional files changed: - sw/source/ui/docvw/postit.cxx - sw/source/ui/shells/drwtxtsh.cxx - sw/source/ui/uiview/viewdraw.cxx
Additional files changed: - sc/inc/scmod.hxx - sc/inc/unonames.hxx - sc/inc/viewopti.hxx - sc/sdi/app.sdi - sc/source/core/tool/viewopti.cxx - sc/source/ui/app/inputhdl.cxx - sc/source/ui/app/scmod.cxx - sc/source/ui/app/scmod2.cxx - sc/source/ui/docshell/docsh3.cxx - sc/source/ui/unoobj/viewuno.cxx - sc/source/ui/view/gridwin4.cxx - sc/source/ui/view/viewdata.cxx
Fixed in CWS tl56.
- sw/source/core/doc/doclay.cxx - sw/source/ui/uiview/view0.cxx
Verified in CWS tl56.
Reassigned to me.
OK in OOO300_m15. Closed.
Note: the removed items are (see spec, page 11): - Old German spelling from Options list box - Check in all languages from Options list box - Do not mark errors from Options list box
Adding the comment from issue 69451 about the reasoning for removing the "spell in all languages" option: b) Much more crucial however is that "spelling in all languages" is actually a very bad idea with grammar checking. A good grammar checker needs to rely on the analysis of the sentence thus e.g. it needs to identify verbs, nouns, object, subject etc. And if the spelling errors are not fixed first the grammar checker can not properly do those tasks (the severity of this might differ from language to language though). That's also the reasoning why the dialog always displays the spelling errors first and only after those the grammar errors. If you would now have a French word in an English sentence the grammar checker can not make sense of it, and if by "spelling in all languages" enabled that French word is not marked as incorrect by the English spell checker because it is known by the French spell checker then it may happen that some grammar error may slip through unnoticed because the grammar checker can not find it with that misspelled word. And that would contradict the whole idea/effort put into grammar checking.