Apache OpenOffice (AOO) Bugzilla – Issue 85991
Taking account of leading value in positioning characters
Last modified: 2017-05-20 11:15:54 UTC
Basic functions for issue 85422, issue 85430 and others. This patch tries to - add a method GetLeading() besides GetAscent() and GetHeight() - keep a leading value in a class SwLinePortion for later use
Created attachment 51455 [details] Patch revison 2008-02-11
fme->tora: Thank you for your patch! I suggest to change the existing GetDefaultAscentAndHeight() function instead of introducing a second one. Please have a look.
Reassigning this Patch proposal to FME.
tora->fme: That makes sense. I will follow you.
Set target to 3.x.
fme->tora: I created a cws (fmepatches02) for this issue.
tora->fme: Great! Thanks a lot. I am submitting the latest patch of this issue in a week. The patch will be a part of efforts from the project [2]. Source codes of Release 2008-02-29 [1] have a problem with layout of ruby text. A ruby text portion is unexpectedly chopped by the neighbor line. The bug came when I introduced an idea of RealRubyHeight to attempt of solving another problem that the first text portion of a line is wrongly positioned. [1] http://wiki.services.openoffice.org/wiki/Jsdp2007 [2] http://wiki.services.openoffice.org/wiki/Grid_%28lines_and_spacing%29 Ciao, Tora
fme->tora: Any new on this? Is this still bing worked on or is the patch "ready for review"? In this case I will review the patches for issue 85991 and issue 85422 and add them to a cws.
fme->tora: Is your work on this finished? Did you make sure that this does not interfere with pflin's new grid implementation? If so, please make sure to have your patch based on a recent DEV300 version and send this issue back to be, I'll review issue 85991 and issue 85422 together and integrate them.
tora->fme: I have started working on this and related issues with DEV300_m6. The patch file attached in February was based on OOo 2.3.0. A new, up-to-date patch that might cover issue 85991 and issue 85422 would be available soon.
Created attachment 53399 [details] A patch to BEA300_m1, covering i85991, i85430, and i85422.
fme->tora: Thank you for your patch. This is really quite a lot of code changes ;-) I had a first look at your patch and like to give you some feedback. First, I have set up a cws ('rubyadjust') and committed your patch to that cws. Please make any further patches basing on this cws, this way it is much easier for us to have your work in sync with the current milestones. So here are my comments: 1. Shouldn't we initialize the ruby height values in the constructor instead of WhichTxtPor()? 2. I see that in ::PaintMultiPortion the meaning of bHasGrid has changed. Is this intended? 3. I'd like to make sure that the overall layout of the document has to remain stable for existing documents. If the position of the glyphs inside a line change, that's acceptable. But we should avoid changing e.g., line heights. I think the code in ::CalcRealHeight might change the layout of existing documents, is this correct? In this case I suggest to implement a new (hidden) compatibility flag (see doc.hxx) that makes sure that any layout related code changes do not affect old documents. 4. Please add some more comments to the changed code, this way it is much easier for me to review your changes. 5. Some of the new members nRubyHeight* in SwLinePortion are only set for ruby multi portions I guess. In this case I suggest to move the values to the multi portion.
tora->fme: Thank you for your consideration and invaluable comments. I will try to do that one by one.
I'm adding this comment to all open issues with Issue Type == PATCH. We have 220 such issues, many of them quite old. I apologize for that. We need your help in prioritizing which patches should be integrated into our next release, Apache OpenOffice 4.0. If you have submitted a patch and think it is applicable for AOO 4.0, please respond with a comment to let us know. On the other hand, if the patch is no longer relevant, please let us know that as well. If you have any general questions or want to discuss this further, please send a note to our dev mailing list: dev@openoffice.apache.org Thanks! -Rob
Reset assigne to the default "issues@openoffice.apache.org".