Issue 80286 - Use single multi-path for dictionary pathes
Summary: Use single multi-path for dictionary pathes
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 680m222
Hardware: All All
: P3 Trivial with 1 vote (vote)
Target Milestone: OOo 3.0
Assignee: stefan.baltzer
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks: 72559
  Show dependency tree
 
Reported: 2007-08-02 11:48 UTC by thomas.lange
Modified: 2009-07-20 15:56 UTC (History)
6 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description thomas.lange 2007-08-02 11:48:06 UTC
Currenty we have a "Dictionary" and a "UserDictionary" there should only be only
a single mulit-path named "Dictionaries".

Notes: 
a) Currently "Dictionary" points to "$(insturl)/share/wordbook/$(vlang)" and
"UserDictionary" points to "$(userurl)/wordbook". Those two are for the
user-dictionaries (the ones that are independent of the spellchecker).

b) There is also the "Linguistic" path "$(insturl)/share/dict" where all the
files that belong to the SO linguistic are installed.
And hard coded the location "$(insturl)/share/dict/ooo" is used for the files
that belong to the OOo linguistic (lingucomponent).
This path should probably addressed as well.
Comment 1 thomas.lange 2007-08-06 13:45:19 UTC
Files changed:

- officecfg/registry/data/org/openoffice/Office/Paths.xcu

- linguistic/inc/misc.hxx
- linguistic/source/convdiclist.cxx
- linguistic/source/dlistimp.cxx
- linguistic/source/misc.cxx
- linguistic/source/supplang.cxx

- svtools/inc/svtools/pathoptions.hxx
- svtools/source/config/defaultoptions.cxx
- svtools/source/config/pathoptions.cxx

- sfx2/source/appl/appcfg.cxx

- svx/inc/unolingu.hxx
- svx/source/dialog/SpellDialog.cxx
- svx/source/dialog/optdict.cxx
- svx/source/dialog/optpath.cxx
- svx/source/dialog/treeopt.cxx
- svx/source/editeng/unolingu.cxx

- sw/source/ui/lingu/olmenu.cxx
Comment 2 thomas.lange 2007-08-07 11:55:00 UTC
Files changed:

- lingu/source/nibsoft/ksspellimp.cxx
- lingu/source/wrapper/prxwrap.cxx
- lingu/source/wrapper/prxwrap.hxx
Comment 3 thomas.lange 2007-08-07 11:56:53 UTC
.
Comment 4 thomas.lange 2007-08-07 11:59:15 UTC
.
Comment 5 thomas.lange 2007-08-07 12:23:13 UTC
.
Comment 6 thomas.lange 2007-08-08 07:37:09 UTC
.
Comment 7 thomas.lange 2007-08-10 11:27:33 UTC
Files changed in CWS tl41:

- linguistic/source/hyphdsp.cxx
- svx/source/editeng/unolingu.cxx
- sw/util/makefile.mk

Also changed:
- lingucomponent/source/hyphenator/altlinuxhyph/hyphen/hyphenimp.cxx
- lingucomponent/source/spellcheck/spell/sspellimp.cxx
- lingucomponent/source/thesaurus/libnth/nthesimp.cxx


tl->dnaber, nemeth, laurantgodard: with this CWS lingucomponent will also make
use of the now multi-pathes 'Dictionary' and 'Linguistic'. The old
'UserDictionary' path is no longer.  The new path setting in Path.xcu is made to
work with the current setup (OOo 2.x) and will thus include the pathes where
dictionary get installed today.

Later on downloadable dictionaries should only be installed in one of the
'Linguistic' pathes only. The 'Dictionary' Path should only be used for
user-dictionaries used in "Tools/Options/Language Settings - Writing Aids" and
the spell check dialog.
It is not yet decided about the exact pathes to be used later on.

This change is to prepare for having or allowing the linguistic dictionaries to
be installable as extensions in the future.
Comment 8 milek_pl 2007-10-09 23:10:03 UTC
adding myself to CC
Comment 9 thomas.lange 2007-12-03 16:13:49 UTC
.
Comment 10 thomas.lange 2008-02-14 15:31:44 UTC
Further changes:

- linguistic/source/dicimp.cxx
- linguistic/source/dicimp.hxx
- linguistic/source/dlistimp.cxx
- linguistic/source/dlistimp.hxx
Comment 11 thomas.lange 2008-02-14 16:06:22 UTC
TL: Dictionaries are no only editable/deletable if they reside in the write path
of the configured Dictionary multi-path.

Note: Previously the read-only flag of the actual file was evaluated.
However it seems that the flag was not properly set by the installation since
long since...
The drawback now is that we can no longer see the content of read-only dictionaries.
It looks like the spec should get changed a little bit to at least allow
browsing of the content...

TL->SBA: If you agree feel free to file an issue for it.
Comment 12 thomas.lange 2008-02-19 14:34:55 UTC
.
Comment 13 thomas.lange 2008-02-27 08:58:44 UTC
.
Comment 14 stefan.baltzer 2008-03-11 14:56:32 UTC
Verified in CWS tl41.
Comment 15 Regina Henschel 2008-07-14 19:07:17 UTC
Issue 70333 was closed because of this issue, but there is still no way to set
the path of user defined wordbooks, nor for other dictionaries at all. I use
German OOoDEV300_m24 on WnXP.
Comment 16 thomas.lange 2008-07-15 07:41:56 UTC
TL->regina:
The pathes that got removed from the UI at some point were removed because the
users most likely broke some functionality if they changed it.
This is of course true for the linguistic path settings as well.

1a) Since OOo now uses extension dictionaries there is not much use for the
dictionary path that was used for downloaded dictionaries anymore.

1b) However since some distributions like to use system wide dictionaries those
settings can still be changed in the configuration. That is the system
administrator that installs OOo can add a path where to look for system wide
installed dictionaries. But this is clearly sth. the normal user should not be
allowed to change.

2) And for user-dictionaries this usually should also not be changed at the
users discretion because if a dictionary is editable or not is decided upon if
the dictionary resides in the share or user layer of installation.

However if you still feel there is the need to allow the user to add some paths
to the existing ones in the UI (without modifying or removing the default
settings!) you may write an issue that this should be allowed.
Comment 17 thorsten.ziehm 2009-07-20 15:56:40 UTC
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues