keyword

This is new feature request.

Any volunteers?

This feature is the GSOC of Omer Bar-or, for more details see
http://wiki.services.openoffice.org/wiki/MacOSX:_Address_book_integration

I don't know his OOo nickname so i don't reassign this issue to him.

Hello! I am Omer Bar-or, and I am currently working on this feature. I have
added myself as CC (nick: cremlae). Please feel free to assign this issue to me
as well.

Issue reassigned to cremlae, on his demand :-)

Thank you !

Adding macport cc, so that we keep up to date with the issue.

Removed keyword (task is for both X11 and Aqua) and changed version to m217.

Accepted issue (sorry for the spam - I didn't see this option until now).

I have finished an initial version of the Mac OS X address book integration and
am about to attach the patch files here. I also created a cws for it called
"macaddressbook01" and assigned this as a task to it.

The patch files are:
1) macaddressbook01_integrate_ab.patch
2) macaddressbook01_macab_driver.tar

(1) is for changes to files already in existence (in milestone m217 with cws
aquavcl01), and (2) is for files that I created (a new directory called macab in
connectivity/source/drivers/). Both are applied from the root OOo directory.

For more information, please see my blog:
http://tpa.omer.bar-or.org/posts/OpenOffice.org/

Created attachment 46608 [details]
Patch for files already in OOo - integrates the Mac Address Book driver into OOo

Created attachment 46609 [details]
a tarball with new files - the macab driver itself (creates directory: connectivity/source/drivers/macab/)

If you apply the patches and the tarball, to integrate the address book:

1) Select file->Wizards->Address Data Source...
2) You should see an option called "Mac OS X Address Book" - select it and click
"Next."
3) If you have any groups in your address book, you'll see a screen for
selecting your main table with "Address Book" followed by all of your groups. I
usually select "Address Book."
4) Rename the data source if you want to, and click "Finish."
5) View your data sources. You can do this in many ways: press F4, click on the
"Data Sources" icon in the toolbar, or select: View->Data Sources.

Now, you should see the address book as the data source you just added. (For me,
the aqua build opens it automatically, while the X11 build only shows the data
source's name ("Addresses," unless you renamed it in step 4), and you have to
expand it, and then expand "Tables" to see the available tables in the data
source, including "Address Book," and all of your groups.) 

Created attachment 46620 [details]
Patch to code in macaddressbook01_macab_driver.tar attachment to build with OpenOffice_2_2_1 cvs tags

Attached macaddressbook01_macab_driver.patch should anyone desire to build Omer
Bar-or's code with any of the OOo 2.2.1 release tags with either gcc 4.0.1 or
3.3. The only change in this patch is to enclose all Carbon.h and AddressBook.h
includes with premac.h and postmac.h includes to avoid colliding typedefs for
the TimeValue data type in Carbon.h and within the sal module's include files.

pluby: Thanks for your contribution.

Is it submitted to OOo from Patrick Luby (JCA) as stated at http://www.openoffice.org/copyright/
copyrightapproved.html or from some other entity?

Yes. I (Patrick Luby) am the author of the patch and by posting it in this bug,
the patch is subject to the OOo JCA.

pluby: thanks for clear statement.

I asked, because in CZ, if you are an employee of a company, all code produced by you is copyrighted by 
the company...

Anything attched to IssueZilla, in theory, is subject to JCA.  The terms of the JCA are a legal agreement 
between Sun Microsystems and the original author of the code being submitted that provides Sun 
Microsystems with identical rights to Sun Microsystems as the submitter.

I am an original CA signer and have never agreed to JCA;  anything I submit via IZ automatically has all 
legal rights assigned to Sun Microsystems and my own claims to ownership are forefit.

Anything that either Patrick or I do not directly submit for approval by Sun Microsystems is not subject 
to any previous agreement.

After all this time I would have thought you would have been able to catch up on the legal terms under 
which you contribute to OpenOffice.org.

Hi Ed,

nice to know you read OOo IssueZilla.

As the first sentence in your comment is false (people who have never heard about JCA do submit their 
patchsets via OOo IssueZilla), I can't comment more on your statements because you base them and false 
assumption.

All code submitted for inclusion in the OOo repository is subject to the JCA.  This is fact.  Go see section 
4b under the link from "Policies and Terms of Use" at the bottom of the IZ page:

http://www.sunsource.net/TUPPCP.html

pjanik: Good point about the employer issue. Fortunately, the company that I
work for is a California corporation and my workplace is in California so
California employee rights laws are applicable.

IANAL, but when a small company tried to give me a contract that didn't look
right to me, I learned that in California, you own what you produce if you
produce it on your own time.

Of course, if your employer pays you to do certain work, it is generally theirs.
However, if you create work outside of your job, California law generally
recognizes that it is you work. IIRC, this little legal right is sometimes
called "moonlighting rights" for the fact that it allows and protects employees
to create their own works while holding down a regular job.

Sadly, many other states with the United States have laws that generally give
ownership to the employer even if you perform the work outside of your job.

openstep: right. And thus if we WANT TO (and we want!) to include this code, we have to be sure it is 
covered by JCA. This applies to Omer Bar-or as well as to Patrick's change to Omer's code.

I'm just checking the status.

ericb->cremlea

Sorry, I was away all the week end, and cannot help you as expected.

Waiting, I'm glad to see attached patches, and I confirm Patrick Luby and Omer Bar-or have JCA accepted.

Created attachment 46706 [details]
Updated macaddressbook01_macab_driver.tar attachment to build with OpenOffice_2_2_1 cvs tags

FYI. Attached is a new macaddressbook01_macab_driver.patch that replaces the
previous patch of the same name. This patch includes the previous fixes plus a
fix for a crashing bug when unexpected NULL values are retrieved from the
Address Book database discovered in NeoOffice bug 2515
(http://bugzilla.neooffice.org/bug.php?op=show&bugid=2515).

cremlae->pluby: Good catch, and thank you for the patch! I've created a new
issue for the crash (issue 79512), and I am about to post a slightly modified
version of your patch there (and without the premac and postmac fix, which is a
different issue).

cremlae->pluby: FYI. I have confirmed that your patch in issue 79512 plus my
first macaddressbook01_macab_driver.patch patch works better than my second
macaddressbook01_macab_driver.patch patch. So, my second patch should be ignored.  

I just committed pluby's first patch (premac/postmac) to cws macaddressbook01.
Every patch after that one has its own issue.

Some (many, in fact) files contain DOS lineendings. Please remove them.

All files in connectivity/source/drivers/macab/ should now have only Unix
line-endings.

Set target

All issues fixed -> this isssue is fixed too

@cremlae:  please verifiy if all DOS endlines in the code have been removed

Address book integration is verified as complete.

@ericb: Sorry to take so long to respond, but yes, all DOS line endings were
removed on July 29th.

This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues