Apache OpenOffice (AOO) Bugzilla – Issue 75724
javadoc documentation out-of sync for Convert.java
Last modified: 2008-05-16 03:28:10 UTC
xmerge/source/xmerge/java/org/openoffice/xmerge/Convert.java contains: /** * Adds the original Document to the Convert Class. This * is to be used for merges. If this Document is added then * it is assumed that a convert with merge is the desired * operation. * * @param name The <code>Document</code> name. * @param is <code>InputStream</code> object corresponding * to the <code>Document</code>. * * @throws IOException If any I/O error occurs. */ public DocumentMerger getDocumentMerger(Document origDoc) throws IOException { DocumentMergerFactory myDocMergerFactory = ci.getDocMergerFactory(); DocumentMerger merger = myDocMergerFactory.createDocumentMerger(origDoc); return merger; } The parameter-list is out of sync - and the description "add a document" doesn't really match the function name "get....", the function returns a merger-object, but the documentation doesn't mention it - so I'm not sure whether the documentation still matches that function at all.
Svante, xmerge is your topic.
Added the issue to CWS xsltfilter07 as it is close to the patches. Going to investigate this further, when the other patches are integrated.
Adapted the Javadoc, fixed in CWS XSLTFILTER07.
SUS->LO: Could you please verify this fix in the source code?
looks good
ready to be closed after integration
This Issue is 'Verified' and not updated in 1yr+, so Closing. A Closed Issue is a Happy Issue (TM). Regards, Andrew Cleaning-up and Closing old Issues as part of: ~ The Grand Bug Squash, pre v3 ~