Issue 71827 - null variant behaviour is not compatible in compatiblity mode
Summary: null variant behaviour is not compatible in compatiblity mode
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: scripting (show other issues)
Version: OOo 2.1
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 2.4
Assignee: sled10guy
QA Contact: issues@framework
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-21 16:58 UTC by noel.power
Modified: 2009-07-20 14:55 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
patch file (3.11 KB, patch)
2006-11-21 16:59 UTC, noel.power 		no flags Details | Diff
test document (11.33 KB, application/vnd.oasis.opendocument.spreadsheet)
2006-11-21 17:00 UTC, noel.power 		no flags Details
test document (12.04 KB, application/vnd.oasis.opendocument.spreadsheet)
2006-11-21 17:00 UTC, noel.power 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description noel.power 2006-11-21 16:58:22 UTC 
So, in some cases I'm not sure whether these are bugs with ooo-basic or just
behaviour that highlights the differences between vb and openoffice basic. 
I will attach a patch here to align the behaviour in compatibility mode.

I think though an example is better, I've constructed two test documents, one
with the compatibility option turned on, there are some macro tests included in
the document that when run show the errors ( VariantTest.ods ) 

I also will attach a similar document with tests ( NonVBAVariantTest.ods ) that
should be used to verify the existing ooo-basic post application of the patch

so what I guess needs to be done is 
a) decide if any of these are genuine errors in the 'standard' non-compatible
ooo-basic mode
Comment 1 noel.power 2006-11-21 16:59:22 UTC 
Created attachment 40804 [details]
patch file
Comment 2 noel.power 2006-11-21 17:00:04 UTC 
Created attachment 40805 [details]
test document
Comment 3 noel.power 2006-11-21 17:00:30 UTC 
Created attachment 40806 [details]
test document
Comment 4 noel.power 2006-11-21 17:01:12 UTC 
change to patch ( for review )
Comment 5 ab 2006-11-24 07:32:36 UTC 
STARTED, not evaluated yet
Comment 6 ab 2007-01-02 12:21:09 UTC 
ab->npower: Back to you to assign it to the next npower cws.
Comment 7 noel.power 2007-01-08 09:55:29 UTC 
.
Comment 8 pavel 2007-01-24 11:34:48 UTC 
move to 2.3.
Comment 9 Mathias_Bauer 2007-04-10 11:12:44 UTC 
Noel, will you integrate this patch or should we close the issue?
Comment 10 noel.power 2007-04-23 14:36:56 UTC 
fixed in npower7
Comment 11 noel.power 2007-05-17 17:37:42 UTC 
Note for testing,

the test document(s) is pretty comprehensive, should say pass when running the
tests.

note: the button binding doesnt work for the variant test document ( this is the
one running in vba compatible mode ) ( I am not going to upload a new version to
fix that ) please just run the macro manually from the basic IDE
Comment 12 noel.power 2007-07-11 12:48:12 UTC 
for qa
Comment 13 noel.power 2007-08-07 10:13:11 UTC 
change target
Comment 14 noel.power 2007-08-07 10:15:17 UTC 
change target
Comment 15 sled10guy 2007-08-28 16:19:25 UTC 
Ran test documents (NonVBAVariantTest.ods and VariantTest.ods) on released
SLED10 SP1 OOo 2.1.14, Windows OOo 2.1 (Build 2007-06-04) and cws-npower7-m217.
Below are the results returned in the msgbox after pressing the "Push to Test"
button:
• Test Results
• =============
• Tests passed: 34
• Tests failed: 0
‣ RESULT: Test Passed
Comment 16 thorsten.ziehm 2009-07-20 14:55:29 UTC 
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues