Apache OpenOffice (AOO) Bugzilla – Issue 59985
Build XmlSearch with upstream xt.jar
Last modified: 2008-05-16 03:33:54 UTC
XmlSearch requires the xt.jar from external/common. As far as I can see this jar is a binary-only, modified version of xt 19991105. That makes it unusable for some distributions. I'll attach a patch to build with an unpatched xt. I moved the modified class to XmlSearch and renamed it so that it doesn't conflict with the unmodified class from the unpatched xt. It is still in xt's namespace because it needs access to package-private xt classes. I believe this is not a problem, because the class is only necessary at build-time, where we can make sure that the xt.jar in use has those package-private classes. The patch depends on the patch from Issue 58308. mh: what's the correct way (wrt. licensing) to integrate this patch? The patch contains a modified file from xt, so it's not entirely covered by my JCA.
Created attachment 32867 [details] Patch
I could also provide a patch to build xt from source (in its own module) and build the xt-derived code in that module.
Created attachment 33893 [details] reworked xt diff -> xt module, configs, XmlSearch changes, depends on bug 52974
Created attachment 33894 [details] use system xt with native HelpLinker, depends on bug 54692
You may have a look at bug 61278 for a workaround to gcj 4.1 bug (gcc PR19870). Building module xt with broken gcj versions. I will add that workaround for ooo-build patch.
@mh: Please find an appropriate owner and or component - at least it's not me. I've no idea what you're talking about.
set target
Created attachment 34782 [details] Fix Java 5 breakage (insert reference to an "closed invalid" issue here)
so we need to review XSLTransformEngine.java by James Clark, what is the source were this file comes from ?
original source is from: http://www.blnz.com/xt/index.html http://www.blnz.com/xt/xt-20051206-src.zip stripped source used for OOo is from: http://go-oo.org/packages/xt/xt-20051206-src-only.zip stripped source is created by the script: $SRC_ROOT/xt/download/build-xt-src-only.sh I hope this information is helpful. :) I will attach updated patches soon. I do not want to see the gcj hack applied to the xt source.
Created attachment 38081 [details] m179; delete cruft.
Created attachment 38082 [details] m179; use system xt.jar with native HelpLinker
mh: are you referring to the comment "Derived from: Id: XSLTransformEngine.java 96 2005-02-28 21:07:29Z blindsey"? in the XmlSearchXSLTransformEngine.java file? The original file is in the xt source zip file that geki described (in xt-20051206/src/xt/java/com/jclark/xsl/dom). The changes are (use diff -uw to ignore whitespace changes caused by the longer class names): - rename a copy of the class from XSLTransformEngine to XmlSearchXSLTransformEngine - add a transform overload to the TransformImpl inner class, with the argument list that XmlSearch expects. Implementation is obviously similar to the existing transform method, but uses the internal xt types instead of the standard W3C DOM types. - add getNameTable and getSourceLoadContext, as expected by XmlSearch, both simply forward the call to the internal Engine. The current binary xt.jar made similar changes (without the rename, hence the changes to XmlIndexBuilder.java); can't say for sure, as I don't have the source, but after experiments with the binary xt.jar and reading of xt example code; I believe the changes are similar.
reassign to me
fixed in cws systemxt
where is xt-xmlsearch.jar expected to come from? can see it usage but not trace of its origin
xt. See xt/src/com/jclark/xsl/makefile.mk
.
setting target matching the CWS
This Issue is 'Verified' and not updated in 1yr+, so Closing. A Closed Issue is a Happy Issue (TM). Regards, Andrew Cleaning-up and Closing old Issues as part of: ~ The Grand Bug Squash, pre v3 ~