Apache OpenOffice (AOO) Bugzilla – Issue 49174
gengal: Utility to generate OO.o gallery files
Last modified: 2005-11-14 12:28:11 UTC
Michael Meeks and me created a commandline tool, which allows to generare and update OOo galleries from given bitmaps. The tool consists of the following files: <OOO_HOME>/program/gengal # only on Linux <OOO_HOME>/program/gengal.bin <OOO_HOME>/program/gengal.rdb It provides the follwing functionality: $ <OOO_HOME>/program//gengal --help Utility to generate OO.o gallery files using: gengal --name <name> --path <dir> [ --destdir <path> ] [ --number-from <num> ] [ files ... ] options: --name <theme> defines a name of the created or updated theme. --path <dir> defines directory where the gallery files are created or updated. --destdir <dir> defines a path prefix to be removed from the paths stored in the gallery files. It is useful to create RPM packages using the BuildRoot feature. --number-from <num> defines minimal number for the newly created gallery theme files. files lists files to be added to the gallery. Absolute paths are required. I will attach 4 patches. The tool was developed in some stages. I did not merge the changes because you might not like a particular feature and the separate patches would be helpful then :-) 1st patch provides basic version of the tool. It does not provide the possibility to define the destdir and there is an ugly option --num implemented in the shell script 2nd path adds the option --destir 3rd patch adds the option --num-from instead of the ugly --num option. Also it cleans up the shell wrapper. 4th path allows to build gengal with gcc-4.0. It makes the necessary symbols visible. I am open for any reminders and can rework the patches on request.
Created attachment 26071 [details] The basic version of the utility
Created attachment 26072 [details] This patch adds the --destdir option
Created attachment 26073 [details] This patch adds the --number-from option instead of the uglu --num option. Also it cleans the shell wrapper.
Created attachment 26074 [details] This patch allows to build gengal with gcc4
Reassigned. Please handle.
Petr - the patch set looks a little confusing - even to me :-) Any chance you can re-generate it splitting it, so the patches are not incremental: ie. re-generate new files vs. /dev/null, and split out the pieces that patch the core code ? The core changes to svx/ are really rather trivial here, it's a shame to hide that fact :-)
OK, I have re-merged the four patches and created another 3 patches that are not incremental.
Created attachment 26193 [details] This patch adds the new source file, wrapper and makefile
Created attachment 26194 [details] This patch includes the necessary changes in the core code of the svx module
Created attachment 26195 [details] This patch includes the necessary changes in the scp2 module
Is it currently part of official source or it will be part?
kami - well of course I'd love to see this in 2.0.x - and since the core changes are really rather minimal / trivial - I don't see why that shouldn't happen. Re-targetting to 2.0.1 - hope that's ok. It'd be nice to have some up-stream comment.
I will add this patch to OOo 2.0.1 in cws impress58
I can't build your patch, I get the following error when linking svx gengal.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) pu blic: static unsigned char __cdecl ucb::ContentBroker::initialize(class com::sun ::star::uno::Reference<class com::sun::star::lang::XMultiServiceFactory> const & ,class com::sun::star::uno::Sequence<class com::sun::star::uno::Any> const &)" ( __imp_?initialize@ContentBroker@ucb@@SAEABV?$Reference@VXMultiServiceFactory@lan g@star@sun@com@@@uno@star@sun@com@@ABV?$Sequence@VAny@uno@star@sun@com@@@4567@@Z ) referenced in function "public: virtual void __thiscall GalApp::Main(void)" (? Main@GalApp@@UAEXXZ) ..\..\wntmsci10\bin\gengal.bin.exe : fatal error LNK1120: 1 unresolved externals
What milestone do you use for your build? Do you use gcc4 with the visibility feature?
I use milestone m118 with windows non pro
I imagine that the Win32 linker is more pernickerty about deps. Can you add $(UCBHELPERLIB) to the APP1STDLIBS in svx/source/gengal/makefile.mk and try again ? - I guess there may be a couple of other missing pieces in there too. Sorry for the pain - we don't see that on Linux.
Ok that did it, I also had to change regcomp [blablabla] -c libfwl$(UPD)$(DLLSUFFIX)$(DLLPOST) \ -c libucpfile1$(DLLPOST) \ -c libfileacc$(DLLPOST) \ -c libucb1$(DLLPOST) to -c $(DLLPRE)fwl$(UPD)$(DLLSUFFIX)$(DLLPOST) \ -c $(DLLPRE)ucpfile1$(DLLPOST) \ -c $(DLLPRE)fileacc$(DLLPOST) \ -c $(DLLPRE)ucb1$(DLLPOST) a simple compile on at least one windows and one unix plattform for patches would be nice in the future. Anywhay, if this patch doesnt break any regression tests on my cws, consider it done for OOo 2.0.1
sources commited on branch for cws impress58
cool - thanks :-) Of course - with this utility in place, we can tweak a number of other things more easily: extending the web-export gallery stuff automatically, etc. and reduce our patch-set yet further which will be great. Thanks again.
patch verified in cws. @cl->wg, please verify that our normal gallery feature is not harmed by this patch. Please test creation and handling of user themes and also drag'n'drop from to gallery. re-open issue and reassign to wg@openoffice.org
reassign to wg@openoffice.org
reset resolution to FIXED
Verified in CWS.
Closed.