Issue 48676 - Remove or expand limitation on User dictionary
Summary: Remove or expand limitation on User dictionary
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: spell checking (show other issues)
Version: 3.3.0 or older (OOo)
Hardware: All All
: P3 Trivial with 27 votes (vote)
Target Milestone: ---
Assignee: stefan.baltzer
QA Contact: issues@lingucomponent
URL:
Keywords:
: 45317 47097 91476 92755 (view as issue list)
Depends on:
Blocks:
 
Reported: 2005-05-04 06:30 UTC by redndahead
Modified: 2013-02-24 20:42 UTC (History)
4 users (show)

See Also:
Issue Type: ENHANCEMENT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description redndahead 2005-05-04 06:30:27 UTC
If you create your own dictionary the limit on words is 2000.  I would like to
remove this limit or expand it.  I am aware of work arounds to create one
larger, but these work arounds don't allow it to be shown in the dictionary
list.  so I would like ti to be either unlimited or at least 10,000 words.

Adam Moore
Comment 1 ooolist2007 2005-08-15 14:35:31 UTC
*** Issue 45317 has been marked as a duplicate of this issue. ***
Comment 2 kpalagin 2007-05-11 21:00:57 UTC
*** Issue 47097 has been marked as a duplicate of this issue. ***
Comment 3 kpalagin 2007-12-19 18:07:33 UTC
Dear developers,
please consider this feature as our current limitation really needs to be 
reevaluated.
Comment 4 azmanam 2008-02-10 20:05:19 UTC
cc'ing to this issue.

This is a fairly major limitation, and 2000 words seems rather arbitrary.

This also seems like a relatively easy fix.

Please consider fixing this soon.
Comment 5 thomas.lange 2008-07-14 08:57:03 UTC
*** Issue 91476 has been marked as a duplicate of this issue. ***
Comment 6 thomas.lange 2008-07-14 08:57:19 UTC
.
Comment 7 thomas.lange 2008-07-15 08:17:13 UTC
Taking ownership.
Comment 8 thomas.lange 2008-07-15 08:17:36 UTC
.
Comment 9 thomas.lange 2008-07-23 15:02:22 UTC
API files changed in CWS tl56.
Implementation still to be done.

Files changed:
- offapi/com/sun/star/linguistic2/XSearchableDictionary.idl    (new file)
- offapi/com/sun/star/linguistic2/Dictionary.idl    (new file)
- offapi/com/sun/star/linguistic2/XDictionary.idl
- offapi/com/sun/star/linguistic2/makefile.mk
Comment 10 thomas.lange 2008-07-23 15:06:19 UTC
ToDo: 
- make use of XSearchableDictionary now to provide proposals from user
dictionaries, since getEntries must no longer be used.
- change implementation to use hash maps or sth. similar for better performance
with increased size.
Comment 11 thomas.lange 2008-07-25 12:08:44 UTC
Additional files changed:

- linguistic/source/dicimp.hxx
- linguistic/source/dicimp.cxx
- linguistic/source/supplang.cxx
- linguistic/source/misc.cxx
- linguistic/source/spelldta.cxx

- svx/inc/svx/optdict.hxx
- svx/inc/svx/splwrap.hxx
- svx/inc/svx/svgdlg.hxx
- svx/inc/unolingu.xx
- svx/source/dialog/SpellDialog.cxx
- svx/source/dialog/dlgfact.cxx
- svx/source/dialog/dlgfact.hxx
- svx/source/dialog/optdict.cxx
- svx/source/dialog/optdict.hxx
- svx/source/dialog/splwrap.cxx
- svx/source/editeng/editview.cxx
- svx/source/editeng/impedit.cxx
- svx/source/editeng/unolingu.cxx

- sw/source/ui/lingu/olmenu.cxx
Comment 12 thomas.lange 2008-08-14 06:33:28 UTC
*** Issue 92755 has been marked as a duplicate of this issue. ***
Comment 13 kpalagin 2008-10-27 09:16:28 UTC
Thomas,
what is the current status of this issue? Is it integrated?
Target 3.0.1 can't be correct. Did you mean 3.1?

Thanks a lot.
WBR,
KP.
Comment 14 thomas.lange 2008-10-27 09:33:13 UTC
TL->kpalagin: Why can't it be 3.0.1? That's exactly what is going to happen.

But be aware guys by increasing the limit of the dictionary I think it to be
possible to run into UI problems. After all we did never had a list box with
actually 30.000 entries... And that's what may happen now. Thus be careful!
Also the performance for suggestions from the user-dictionaries may go down
compared to before. After all computing Levenshtein Distance for about 15x the
entries as before will not come at no cost.

Thus consider the new limit experimental and report back the problems you run
into. Personally I still do think adding more than 5000 words or so should be
done by adding/extending the spell checker dictionary. That is (now in OOo 3.0)
by providing a personalized dictionary extension... See 
http://wiki.services.openoffice.org/w/index.php?title=Extension_Dictionaries
for a reference. That would have also taken care of the potential UI issue.
Comment 15 thomas.lange 2008-10-27 09:39:24 UTC
TL->kpalagin: I forgot about his one: It is not integrated yet. It will be part
of the current grammar checking CWS to be integrated. Name is tl56.
Comment 16 thomas.lange 2008-10-27 09:39:33 UTC
TL->kpalagin: I forgot about this one: It is not integrated yet. It will be part
of the current grammar checking CWS to be integrated. Name is tl56.
Comment 17 kpalagin 2008-10-27 10:07:23 UTC
Thanks for this enhancement, it is really appreciated.

As far as I know, x.y.1 releases are not supposed to contain new 
features/enhancements, only fixes for major bugs, that is why I thought target 
3.0.1 is incorrect.
Comment 18 thomas.lange 2008-10-27 10:14:07 UTC
It is neither a new feature not even an enhancement (aside from changing the
type of a return value, which was the reason to modify all those files) I just
needed to change on define from 2.000 to 30.000.
Comment 19 thomas.lange 2008-10-29 08:05:17 UTC
.
Comment 20 stefan.baltzer 2008-12-04 16:18:48 UTC
Verified in CWS tl56.
Comment 21 stefan.baltzer 2008-12-04 16:22:04 UTC
Reassigned to me.
Comment 22 tommy27 2008-12-19 00:49:48 UTC
would anyone plase tell me how the thing is supposed to work now?

a- removed any limit
b- 2000 limit was set to an higher value (tell me which one)
c- limit must be set by user as a custom value

thank you
Comment 23 kpalagin 2008-12-19 05:06:49 UTC
Limit is raised to 30000, as specified in comment #19.
Comment 24 tommy27 2009-01-15 09:15:00 UTC
this is a great new feature.

i wonder if there will be a way to merge multiple 2000-words-limit dictionaries 
into a single 30000-words-limit dictionary
Comment 25 thorsten.ziehm 2009-07-20 15:56:06 UTC
This issue is closed automatically and wasn't rechecked in a current version of
OOo. The fixed issue should be integrated in OOo since more than half a year. If
you think this issue isn't fixed in a current version (OOo 3.1), please reopen
it and change the field 'Target Milestone' accordingly.

If you want to download a current version of OOo =>
http://download.openoffice.org/index.html
If you want to know more about the handling of fixed/verified issues =>
http://wiki.services.openoffice.org/wiki/Handle_fixed_verified_issues