Issue 30830 - Problem with full formated documents due to increased rowlimit
Summary: Problem with full formated documents due to increased rowlimit
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: 680m42
Hardware: All All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: oc
QA Contact: issues@sc
URL:
Keywords:
: 37341 (view as issue list)
Depends on:
Blocks:
 
Reported: 2004-06-28 15:59 UTC by oc
Modified: 2013-08-07 15:15 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description oc 2004-06-28 15:59:34 UTC 
Documents which are full formated (e.g. by setting a border from B1:b32000) are
getting bigger in OOo2.0 because of the increased rowlimit and a now changing
formating. The problems are filesize, loading performance, print ranges...
Comment 1 ooo 2004-06-28 17:30:36 UTC 
In other words: styles applied down with no data contained in these cells should
be extended to the new bottom row. The question remains: how many rows are to be
considered for that "no data contained at bottom" criterium? It would be
nonsense to test for a fixed row number 32000, as future versions again may
increase the limit, or people may compile their own version with different
limits, and the same problem would occur again with formats extended down to row
65536.
Comment 2 niklas.nebel 2004-11-17 18:25:05 UTC 
*** Issue 37341 has been marked as a duplicate of this issue. ***
Comment 3 matthias.mueller-prove 2005-01-28 09:58:03 UTC 
Solution:

for each column i
(
   find the last cell that contains content. Coordinates are (i,c)
  Start at (i,c+1) to find a series of cells with uniform visual style of length 84.
    Coordinates of  first cell of  of this series is (i, u)
    The last row to be used for the definition of the range maxi= u-1
)

The maximum of all maxi values is the limit for the print/selection range.
Comment 4 niklas.nebel 2005-01-28 10:36:26 UTC 
I'm doing the change.
Comment 5 niklas.nebel 2005-01-28 18:51:32 UTC 
Fixed on CWS "calc29".
Changed:
attarray.hxx 1.5.292.1
column.hxx 1.13.168.1
attarray.cxx 1.18.168.1
column2.cxx 1.22.168.1
table1.cxx 1.10.184.1

Automatic print ranges, HTML/RTF export, and the Ctrl-End keyboard shortcut now
handle cell formats as described by mmp above.

The formats in these old documents still extend to row 32000 (because that's
what the file content says), but no unnecessary pages are created from the formats.

Loading performance and file size has never been a problem, Excel export was
handled separately (see issue 194).
Comment 6 niklas.nebel 2005-02-14 14:10:23 UTC 
back to QA for verification
re-open issue and try to reassign to oc@openoffice.org
Comment 7 niklas.nebel 2005-02-14 14:10:44 UTC 
try to reassign to oc@openoffice.org
Comment 8 niklas.nebel 2005-02-14 14:10:53 UTC 
try to reset resolution to FIXED
Comment 9 frank 2005-02-17 11:27:02 UTC 
found fixed on cws calc29 using Windows, Linux and Solaris build.
Comment 10 frank 2005-02-17 16:00:18 UTC 
*** Issue 41857 has been marked as a duplicate of this issue. ***
Comment 11 oc 2005-03-18 10:48:49 UTC 
closed because fix available in OOo1.9m87
Comment 12 clespantleri 2010-11-10 16:34:09 UTC 
Created attachment 73223