Issue 124573 - Office does not start when accessibility is activated.
Summary: Office does not start when accessibility is activated.
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: accessibility (show other issues)
Version: 4.1.0-beta
Hardware: All Windows, all
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: Andre
QA Contact:
URL:
Keywords: accessibility
Depends on:
Blocks: winA11y
  Show dependency tree
 
Reported: 2014-04-01 13:17 UTC by Andre
Modified: 2017-05-20 10:35 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 4.1.0_release_blocker+


Attachments
Initialize flag. (561 bytes, patch)
2014-04-01 13:27 UTC, Andre
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Andre 2014-04-01 13:17:48 UTC
How to reproduce:
1. Start OpenOffice
2. Activate accessibility support:
2a. Tools->Options
2b. OpenOffice->Accessibility
2c. Check 'Support assistive techonology tools
3. Restart OpenOffice

Sometimes OpenOffice does not start.
Comment 1 Andre 2014-04-01 13:23:40 UTC
This problem is caused by an uninitialized flag in Desktop::Main() (desktop/source/app/app.cxx):
When the support for assistive devices is active then the access bridge is initialized.  This sets a flag that defines what to do when the initialization failed.  In that case the flag is not modified and, since it is not initialized, contains a random value.  Therefore, sometimes OpenOffice just shuts down.
Comment 2 Andre 2014-04-01 13:27:02 UTC
Created attachment 83052 [details]
Initialize flag.

Initialize bQuitApp flag with sal_False, so that when the initialization of the access bridge fails, OpenOffice does not shut down.
Comment 3 Andre 2014-04-01 13:28:16 UTC
Requesting release blocker status because in some cases OpenOffice fails to start (silently).
Comment 4 jsc 2014-04-01 13:34:05 UTC
grant showstopper flag, sound serious enough and breaks potentially the new accessibility feature
Comment 5 Oliver-Rainer Wittmann 2014-04-01 13:36:11 UTC
OpenGrok tells me that there are two mode code snippets which call <InitAccessBridge> and do not initialize the value of the 2nd parameter:
- in main/vcl/win/source/window/salframe.cxx, method <SalFrameWndProc(..)>
- in main/padmin/source/pamain.cxx, method <MyApp::Main()>
Comment 6 SVN Robot 2014-04-01 13:48:55 UTC
"af" committed SVN revision 1583666 into branches/AOO410:
i124573: Initialize flags to allow acess bridge initialization to fail gracef...
Comment 7 SVN Robot 2014-04-01 13:49:44 UTC
"af" committed SVN revision 1583671 into trunk:
i124573: Initialize flags to allow acess bridge initialization to fail gracef...
Comment 8 Andre 2014-04-01 13:50:55 UTC
I added the initialization in desktop and padmin but not in vcl.  We can do the later on trunk.
Comment 9 Andre 2014-04-01 13:51:10 UTC
Fixed as explained above.
Comment 10 Andrea Pescetti 2014-04-01 14:12:55 UTC
Just for clarity, is this bug compatible with the description from Jacopo Deyla to the dev list? He was testing accessibility in a snapshot and reported: "it closes in the loading screen (after 1/3)".
Comment 11 Andre 2014-04-01 15:05:25 UTC
Yes, that fits.
Comment 12 Regina Henschel 2014-04-01 15:08:05 UTC
I had set "Tools > Options > OpenOffice->Accessibility > 'Support assistive technology tools'" and I observe, that AOO starts but shuts down immediately in many cases. So I thought, that I can solve the problem by clearing the options. But after restart the option is checked again automatically. Do you see this too? And if yes, does the fix solve this problem too?
Comment 13 SVN Robot 2014-04-02 06:08:42 UTC
"steve_y" committed SVN revision 1583887 into trunk:
Issue 124573 - Office does not start when accessibility is activated.
Comment 14 Andre 2014-04-02 06:48:43 UTC
I forgot to mention one important detail.  The bug can only be observed when there is NO screen reader installed.

@Regina: So far I only have seen code that would turn off the 'Support assistive technology tools' flag.  That is done when a screen reader is detected but for some reason the access bridge can not be initialized.
Comment 15 Steve Yin 2014-04-02 09:05:44 UTC
@Andre: I found that the issue can be reproduced when no screen reader or other AT tools running. That's to say the SPI_GETSCREENREADER is not set.

(In reply to Andre from comment #14)
> I forgot to mention one important detail.  The bug can only be observed when
> there is NO screen reader installed.
> 
> @Regina: So far I only have seen code that would turn off the 'Support
> assistive technology tools' flag.  That is done when a screen reader is
> detected but for some reason the access bridge can not be initialized.