Apache OpenOffice (AOO) Bugzilla – Issue 124197
Link button in Hyperlink Toolbar Works Only First Time in Document
Last modified: 2017-05-20 10:35:34 UTC
For example, I want to link the text "Text" to "http://www.text.com" Highlighting "Text" automatically loads "Text" in the first dropdown box. I click and drag the URL to the URL box, which populates that box. Then, the Link button is enabled. The first time I do this in a document, it works flawlessly, assigning the URL to the text in one click. However, this is where the bug comes in, any subsequent attempt to use the link button, on another text that I want to assign a URL, nothing happens. I have to click the link drop button and select "As Text" in order to complete the link.
Please attach example.
will have to try a desktop video capture…
http://youtu.be/v5d-nIbCFts
Thank you bnjroo Confirmed with AOO410m1(Build:9750) - Rev. 1562493 Rev.1562493 Win 7
I took a look. This happens because there is a member 'bSend' which is set to true when the URL gets send to the app. Irritatingly there is no place where it gets reset to false, except that the toolber gets reconstructed, that cannot be intended. Tried to find info about 'bSend' in the history, but no hints. It seems to be intended to not send the URL to the app twice, but even that works well (stepping over setting it). When thinking about at which conditions to reset it to false its pretty much every one, so the question is why it exists at all. Tried to watch changes to the URL string itself, but that is ineffective. Even when resetting every time SvxHyperlinkDlg::EnableLink() is called and enables the Link button it will be reset pretty much all the time. It may have been used to prevent unwanted endless loops when SvxHyperlinkDlg::SendToApp triggers something that indirectly triggers some updates to the URL toolbar and may trigger SvxHyperlinkDlg::SendToApp again, but then it should be sloved locally. I tend to remove the bool and ensure that SvxHyperlinkDlg::SendToApp will not run recursively, testing that...
Works as expected and will not be more risky than before, preparing commit...
"alg" committed SVN revision 1565724 into trunk: i124197 allow URL Toolbar to send URLs to the app more than once
Okay, done.
Noted status change to resolved/fixed. Any timeframe on when this update will be available to end user or how to patch? Thank you.
(In reply to bnjroo from comment #9) > Noted status change to resolved/fixed. Any timeframe on when this update > will be available to end user or how to patch? > > Thank you. Release date of 4.1 unknown to me. Snapshots are available here: http://ci.apache.org/projects/openoffice/#win
Good job ALG & ES Thanks for your help. -LW