Issue 123948 - fix class/struct mismatches
Summary: fix class/struct mismatches
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 4.1.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 122766
  Show dependency tree
 
Reported: 2014-01-02 14:55 UTC by hdu@apache.org
Modified: 2014-04-01 12:23 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description hdu@apache.org 2014-01-02 14:55:26 UTC
C++ classes and structs behave very similarly, except that their default access is different: classes default to "private" access whereas structs default to "public" access. Because of this similarity many compilers treat tolerate that both are treated the same, even though they are different types.

Mixing class and struct declarations/defines is very dubious and it violates the "one definition rule". These mixups should be eliminated from the AOO codebase to improve its C++ compliance-
Comment 1 SVN Robot 2014-01-03 12:59:37 UTC
"hdu" committed SVN revision 1555078 into trunk:
#i123948# fix struct/class mismatch of PrefetchPropertiesFunc's forward decla...
Comment 2 SVN Robot 2014-01-08 13:07:26 UTC
"hdu" committed SVN revision 1556523 into trunk:
#i123948# fix struct/class mismatch from PropertyValue forward declaration
Comment 3 SVN Robot 2014-01-21 16:13:17 UTC
"hdu" committed SVN revision 1560054 into trunk:
#i123948# fix more class/struct mismatches
Comment 4 Oliver-Rainer Wittmann 2014-02-10 09:40:21 UTC
@Herbert: Is this issue solved already?
Comment 5 hdu@apache.org 2014-02-25 09:11:37 UTC
Fixed with the commits above.
Comment 6 hdu@apache.org 2014-04-01 12:23:15 UTC
Closing the resolved issue.