Issue 123532 - Cleanup instsetoo_native/util/makefile.mk
Summary: Cleanup instsetoo_native/util/makefile.mk
Status: CONFIRMED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: 4.1.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-10-23 11:15 UTC by Andre
Modified: 2017-05-20 10:44 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Andre 2013-10-23 11:15:14 UTC 
The makefile.mk in instsetoo_native/util has several small problems and needs a cleanup.  This would also make it easer to add new features/targets, like creating patches.
Comment 1 SVN Robot 2013-10-30 08:27:05 UTC 
"af" committed SVN revision 1536998 into trunk:
123532: Remove last references to URE (already commented out).
Comment 2 SVN Robot 2013-10-30 08:28:25 UTC 
"af" committed SVN revision 1536999 into trunk:
123532: Added help target that prints a short documentation about available t...
Comment 3 SVN Robot 2013-10-30 08:29:22 UTC 
"af" committed SVN revision 1537000 into trunk:
123532: Removed support for deprecated BUILD_SPECIAL flag.
Comment 4 SVN Robot 2013-10-30 08:30:27 UTC 
"af" committed SVN revision 1537001 into trunk:
123532: Factored out MAKE_INSTALLER_COMMAND and GEN_UPDATE_INFO_COMMAND macros.
Comment 5 SVN Robot 2013-10-30 08:31:19 UTC 
"af" committed SVN revision 1537002 into trunk:
123532: Unhacked the hack_msitemplates target to msitemplates.
Comment 6 SVN Robot 2013-10-30 08:32:59 UTC 
"af" committed SVN revision 1537003 into trunk:
123532: Renamed hack_msitemplates target to msitemplates.
Comment 7 SVN Robot 2013-10-30 08:34:47 UTC 
"af" committed SVN revision 1537006 into trunk:
123532: Hide one warning about changes of %-target handling in dmake 4.5.
Comment 8 Andre 2013-10-30 08:55:22 UTC 
The previous changes to instsetoo_native/util/makefile.mk changed/fixed the following:
- Removed the already commented out references to URE.  Building the URE is no longer supported.
- A new target 'help' prints out all supported targets.  This provides a reminder of which targets are available and also shows short documentations (where known) about the targets.  Also some variable values are shown.
- Removed support for the deprecated BUILD_SPECIAL flag.
- Improved the way the .idt files are copied into the output tree (relevant only on Windows).  Instead of simply copying them every time, there are now make rules that only copy missing files.
- Removed one warning that is shown by dmake that tells the developer that there is a certain feature available since version 4.5 (we use 4.12).  There are other warnings like that but this one is visible when dmake is called without specifying a target.
Comment 9 SVN Robot 2013-12-10 08:52:07 UTC 
"af" committed SVN revision 1549788 into trunk:
123532: Prevent more silly warnings.
Comment 10 Andre 2013-12-10 08:55:22 UTC 
Prevent more warnings about a feature added to old dmake 4.5 (the warning just tells you that it now works) by replacing

openoffice_%{$(PKGFORMAT:^".")} :

with 

$(foreach,P,$(PACKAGE_FORMATS) $(foreach,L,$(alllangiso) penoffice_$L.$P)) .PHONY :

ie by avoiding the % in targets that don't use it anyway.
Comment 11 SVN Robot 2013-12-12 17:38:19 UTC 
"hdu" committed SVN revision 1550457 into trunk:
#i123532# avoid build breaker when pkgformat contains an "archive" target
Comment 12 SVN Robot 2013-12-17 13:53:42 UTC 
"af" committed SVN revision 1551541 into trunk:
123532: Added list of known package formats.
Comment 13 Oliver-Rainer Wittmann 2014-02-10 09:33:31 UTC 
@Andre: Is this issue solved already?
Comment 14 Marcus 2017-05-20 10:44:54 UTC 
Reset the assignee to the default "issues@openoffice.apache.org".