Issue 122792 - Extra text in a Base error message
Summary: Extra text in a Base error message
Status: CLOSED FIXED
Alias: None
Product: Base
Classification: Application
Component: code (show other issues)
Version: 4.0.0-dev
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.1.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-07-21 12:35 UTC by Andrea Pescetti
Modified: 2022-10-28 12:54 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Andrea Pescetti 2013-07-21 12:35:47 UTC
It seems that revision 1465678, that included changes in many strings, had the small side effect of joining a Base error message with the second line of a comment ("x-comment").

$ svn diff -r1465677:1465678 main/dbaccess/source/ui/querydesign/query.src 
Index: main/dbaccess/source/ui/querydesign/query.src
===================================================================
--- main/dbaccess/source/ui/querydesign/query.src	(revision 1465677)
+++ main/dbaccess/source/ui/querydesign/query.src	(revision 1465678)
@@ -367,20 +367,17 @@
 String STR_QUERY_SAVEMODIFIED
 {
 	Text [ en-US ] = "$object$ has been changed.\nDo you want to save the changes?" ;
-    Text [ x-comment ] = "For $object$, one of the values of the RSC_QUERY_OBJECT_TYPE resource will be inserted.";
 };
 
 String STR_ERROR_PARSING_STATEMENT
 {
-    Text [ en-US ] = "$object$ is based on an SQL command which could not be parsed.";
-    Text [ x-comment ] = "For $object$, one of the values of the RSC_QUERY_OBJECT_TYPE resource "
+    Text [ en-US ] = "$object$ is based on an SQL command which could not be parsed."
         "(except \"SQL command\", which doesn't make sense here) will be inserted.";
 };
 
 String STR_INFO_OPENING_IN_SQL_VIEW
 {
-    Text [ en-US ] = "$object$ will be opened in SQL view.";
-    Text [ x-comment ] = "For $object$, one of the values of the RSC_QUERY_OBJECT_TYPE resource "
+    Text [ en-US ] = "$object$ will be opened in SQL view."
         "(except \"SQL command\", which doesn't make sense here) will be inserted.";
 };

The right solution is probably to remove the extra line, i.e.,
  "(except..."
from both occurrences. This has l10n implications, so it should be done on trunk before the next string update in Pootle.
Comment 1 Dick Groskamp 2013-07-21 15:39:11 UTC
Removed the x-xomment string ""(except "SQL command", which doesn't make sense here) will be inserted."" from Dutch translation in POOTLE
Comment 2 SVN Robot 2013-07-21 15:54:58 UTC
"pescetti" committed SVN revision 1505405 into trunk:
#i122792# Remove extra text from error message.
Comment 3 Andrea Pescetti 2013-07-21 15:56:35 UTC
Fixed in trunk: extra text removed as discussed with jani on the l10n mailing list.

The fix will become visible only at the next Pootle update (this means: the English string will appear correctly shortened in Pootle only after a Pootle update; then translators will probably see the old translation as a suggestion and will need to review it).