Issue 121609 - When Copy-Pasting a draw object with bitmap tile filling to a paint program as bitmap, visible gaps appear in the tiling
When Copy-Pasting a draw object with bitmap tile filling to a paint program a...
Status: RESOLVED FIXED
Product: Draw
Classification: Application
Component: editing
4.0.0-dev
All All
: P3 normal (vote)
: 4.0.0
Assigned To: Armin Le Grand
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-01-11 16:01 UTC by Armin Le Grand
Modified: 2013-07-12 16:34 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation on: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Armin Le Grand 2013-01-11 16:01:10 UTC
ALG: When Copy/Pasting SDrObjects with tile fill gaps appear. Looking into this...
Comment 1 Armin Le Grand 2013-01-11 16:06:21 UTC
ALG: Grepping and taking a look.
Main reason is that in SdrExchangeView::GetMarkedObjBitmapEx the conversion to BitmapEx is done using the path over Metafile. In the Metafile the tiling is geometrically corrcect. When rendering this to a pixel target the tiling is not known in the Metafile and gaps may occurr. This always happens when the renderer tiling does not know about the tiling.
This is not wanted and anyways the taken conversion path over the metafile is error-prone and may create other obstacles. Implementing a more direct way using primitives and tooling to create a BitmapEx instantly.
When at it, unify the way the selected objects are accessed in SdrExchangeView. This is done in DrawMarkedObj and GetMarkedObjModel in a way which sorts FormControls to the end of the list. This is needed for the direct conversion, too, so I create SdrExchangeView::GetMarkedObjects and use/replace it.
Comment 2 Armin Le Grand 2013-01-11 16:16:08 UTC
ALG: Works as expected. Also checked model cretion for transfer and bitmap conversion. Preparing commit...
Comment 3 Armin Le Grand 2013-01-11 16:17:09 UTC
ALG: Okay, done.
Comment 4 SVN Robot 2013-01-11 16:27:50 UTC
"alg" committed SVN revision 1432130 into trunk:
#121609# Made conversion to bitmap more direct