Issue 121579 - Clean-up system mail API
Summary: Clean-up system mail API
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 3.4.1
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.0.0
Assignee: Ariel Constenla-Haile
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-01-03 21:46 UTC by Ariel Constenla-Haile
Modified: 2018-03-12 08:43 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Ariel Constenla-Haile 2013-01-03 21:46:24 UTC 
The com::sun::star::system module provides two services to send mails via a MUA in the target system:

com::sun::star::system::SimpleCommandMail
com::sun::star::system::SimpleSystemMail

These are presented as two different services, but in fact they are the implementation of the same interface (XSimpleMailClientSupplier), one in Windows and the other in *nix systems: 

* SimpleSystemMail is the Windows implementation that uses the Windows Simple MAPI to send mails through the default mail client configured in the Windows system

* SimpleCommandMail is the *nix implementation that launches, via the command line, a mail client configured in the Tools - Options... - Internet - E-mail dialog.

The API should be redesigned to:

* hide implementation details, and present a single service, removing the need to check which service is available on the target platform

* simplify the general naming, removing the redundant "Simple" naming, in services, interfaces, methods, et al. (what seems to be only a reflection of the Windows Simple MAPI)
Comment 1 Ariel Constenla-Haile 2013-01-05 18:56:33 UTC 
Changes applied in revision 1429067

The two main services and the interface they implement have been removed:

com::sun::star::system::SimpleCommandMail
com::sun::star::system::SimpleSystemMail
com::sun::star::system::XSimpleMailClientSupplier

they have been replaced by a new-style service:

com::sun::star::system::SystemMailProvider
com::sun::star::system::XSystemMailProvider

The word "Simple" has been removed from

com::sun::star::system::XSimpleMailClient
com::sun::star::system::XSimpleMailMessage
com::sun::star::system::SimpleMailClientFlags

They are now named

com::sun::star::system::XMailClient
com::sun::star::system::XMailMessage
com::sun::star::system::MailClientFlags


All the methods of com::sun::star::system::XSimpleMailMessage have been converted to interface attributes.