Apache OpenOffice (AOO) Bugzilla – Issue 120927
Import/Export Hyperlink Info of Graphic with Anchor Type Except “As Character” to MS Word Binary File
Last modified: 2017-05-20 11:42:11 UTC
Export Hyperlink Info of Graphic with Anchor Type Except “As Character” to MS Word Binary File
Created attachment 79756 [details] Fix for the issue that can't import/export Hyperlink of graphic & frame for Doc binary file. Root cause: Current in OO doesn't support import/export Hyperlink of graphic&frame from MS binary file. Solution: Add feature for import/export Hyperlink of graphic & frame from MS binary file. Unit test: 1. Doc save as doc: a. Test on Frame with bookmark link, URL, File location, Target Frame, Frame name. b. Test on graphic with bookmark link, URL, File location, Target Frame, name. 2. Odt save as doc: a. Test on Frame with bookmark link, URL, File location, Target Frame, Frame name. b. Test on graphic with bookmark link, URL, File location, Target Frame, name.
Created attachment 79969 [details] Reviewed and Updated Patch Reviewed and Updated Patch
"chengjh" committed SVN revision 1415477 into trunk: Fix issue #120927: Import/Export Hyperlink Info of Graphic with Anchor Type E...
All our buildbots noticed a build breaker introduced by this change: In file included from main/sw/source/filter/ww8/rtfattributeoutput.cxx:29: main/sw/source/filter/ww8/ww8par.hxx: In function 'ReturnType ulimit_cast(Type)': main/sw/source/filter/ww8/ww8par.hxx:383: error: 'numeric_limits' is not a member of 'std' main/sw/source/filter/ww8/ww8par.hxx:383: error: expected primary-expression before '>' token main/sw/source/filter/ww8/ww8par.hxx:383: error: '::max' has not been declared
and another compiler error was: main/sw/source/filter/ww8/wrtw8esh.cxx:2312:6: error: jump to case label [-fpermissive] main/sw/source/filter/ww8/wrtw8esh.cxx:2287:23: error: crosses initialization of 'const SdrObject* pSdrObj' or the same error by a different compiler: main/sw/source/filter/ww8/wrtw8esh.cxx(2312) : error C2361: initialization of 'pSdrObj' is skipped by 'default' label main/sw/source/filter/ww8/wrtw8esh.cxx(2287) : see declaration of 'pSdrObj'
which platform the build breaks appear?
The Linux32, Linux64 and Windows buildbots complained http://ci.apache.org/builders/openoffice-linux32-nightly/builds/331 http://ci.apache.org/builders/openoffice-linux64-nightly/builds/438 http://ci.apache.org/builders/aoo-win7/builds/403 On the other hand I'm no longer sure whether your commit or the warning removals such as revision 1415336 were the reason.
"hdu" committed SVN revision 1415625 into trunk: #i120927# limit scope of case-specific pSdrObj
"hdu" committed SVN revision 1415741 into trunk: #i120927# ww8par.hxx always needs the numeric_limits include
The numeric_limits build problems were fixed with revision 1415741. The build problems described in comment 5 were not directly related to the original change (revision 1415477), but were introduced by the followup change (revision 1415336). These are fixed now with revision 1415625.
Thanks to hdu,we should be careful of the compile difference with platform..