Apache OpenOffice (AOO) Bugzilla – Issue 120848
[From Symphony]"Fit shape to text" property not work after openning ppt by AOO
Last modified: 2012-10-18 07:04:00 UTC
Created attachment 79351 [details] sample file build: AOO trunk r1378003 steps: 1)open ppt sample file with AOO 2)check text in arrow shape expected result: text in shape can fit automatically. actual result: text is out of shape, the "Fit shape to text" property not work normally.
I am investigating this issue.
Root cause: Notched right arrow text rectangular geometry is not defined reasonably. Resolution: Modify its text rectangular definition. Notes: A comparison for text rect in MS and AOO can be seen in attachment "comparison.jpg". To compare the the text rect, set "Fix shape to text" first. You will see MS text rect is more reasonable.
Created attachment 79373 [details] Text rect comparison between MS and Aoo
Created attachment 79374 [details] Patch for this issue
ALG: I have reviewed this patch. It solves the problem, but there is also a egression introduced: When editing the text shape, the yellow controller is working mirrored in the Y-Direcion. Please correct this, it does not happen with the original shape.
@Armin: Can you provide more detail info for reproducing the regression issue?
ALG: Yes. As written. when you select the object (Handles visible) you have one yellow handle. This can be moved hor/ver to change object shape. Horizontal movement works unchanged, but vertical movement is inverted when the patch is applied. It works as expected without the patch. HTH!
With my path, no matter how I changed the shape with the yellow handle, I cannot make it inverted. Can you provide a snapshot for your inverted yellow handle?
ALG: No, i would have to provide a movie to show this, it happens during interaction. It's not about inversion of the object itself. When you move the yellow handle upward, the shape gets smaller vertically. It should get bigger, as without the patch. When you move the yellow handle down, the shape gets bigger vertically. It should get smaller, as without the patch. I can demonstrate life if needed...
Created attachment 79478 [details] Why shape size is adjusted with my patch
@Armin: Getting bigger or smaller is indeed related to my patch. Because text rect is adjusted in my fix and "Fit shape to text" is set for the shape in sample file. This two points result in the change. See my analysis in attachment "Why shape size is adjusted with my patch". I think this behavior is acceptable. You can check another shape "striped right arrow". It also works like that when moving the handle(set property "Fit shape to text" for shape). What's your opinion?
ALG: I tried striped right arrow and you are correct. It also happens with right arrow. It is a general effect when 'resize shape to fit text' is activated. When thinking about it it seems logical; when the shape is resized to the text after the new position is adapted, the position *has* to move again. It is not a good user feedback, but the control (the yellow handle) cannot stay where the mouse pointer is positioned. I agree, it's acceptable behaviour and could only be fixed/changed in a more general way. Maybe moving the handles when interaction is done is a solution. The handle would be shown on its true new position, not under the mouse pointer. This would at least make clear to the user what happens. Thus, review is done. Shall I commit your change?
@Armin: Yes, please go ahead. Thanks.
"alg" committed SVN revision 1384629 into trunk: #120848# Added correct text content frame for NotchedRightArrow AutoshapePatc...
ALG: Okay, done. Thanks for the patch!
ALG: Setting to fixed
text in shape can fit automatically.
Update Target Milestone to AOO 3.5.0.