Issue 120302 - Add support for "AOO" and "Apache OpenOffice" in @since tag
Summary: Add support for "AOO" and "Apache OpenOffice" in @since tag
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: autodoc (show other issues)
Version: 3.4.0
Hardware: All All
: P3 Normal (vote)
Target Milestone: 4.0.0
Assignee: Ariel Constenla-Haile
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-17 23:00 UTC by Ariel Constenla-Haile
Modified: 2022-10-28 12:54 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Patch to support both "AOO" and "Apache OpenOffice" (3.20 KB, patch)
2012-07-18 03:02 UTC, Ariel Constenla-Haile 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Ariel Constenla-Haile 2012-07-17 23:00:30 UTC 
With the change in the product name, newly created IDL documentation should not use @since OOo but @since AOO
Comment 1 Ariel Constenla-Haile 2012-07-18 03:02:24 UTC 
Created attachment 78672 [details]
Patch to support both "AOO" and "Apache OpenOffice"

Adding support for "@since AOO" is rather simple, just add 

 SapiDocu_PE::CheckVersionSyntax_OOo(const String & i_versionPart1)
 {
     return      i_versionPart1 == "OOo"
-            OR  i_versionPart1 == "OpenOffice.org";
+            OR  i_versionPart1 == "AOO"
             OR  i_versionPart1 == "OpenOffice.org";
 }

in main/autodoc/source/parser_i/idoc/docu_pe2.cxx

Adding support for "@since Apache OpenOffice" is a bit of a hack, because it add processing a new token if the first one is "Apache".

With the current patch both

        @since Apache OpenOffice 3.5
        @since AOO 3.5

are supported.
Comment 2 SVN Robot 2012-07-19 22:02:06 UTC 
"arielch" committed SVN revision 1363563 into trunk:
#i120302# - Add support for "AOO" and "Apache OpenOffice" in @since IDL tag
Comment 3 SVN Robot 2012-07-19 22:02:11 UTC 
"arielch" committed SVN revision 1363564 into trunk:
#i120302# - Replace "@since OpenOffice.org" in IDL files
Comment 4 Ariel Constenla-Haile 2012-07-20 21:29:04 UTC 
Fixed in trunk