Apache OpenOffice (AOO) Bugzilla – Issue 120168
[From Symphony] optimize chart saving to improve xls saving performance
Last modified: 2016-04-09 10:41:55 UTC
xls document with many oles(the chart) in it will cost much time when saving.
Root cause: All chart will be persisted as xml format on disk when xls saving, which is time consuming. Resolution: If the chart has not been modified, then no need to update the persist files redundantly.
Created attachment 78597 [details] patch
Created attachment 78598 [details] sample
(In reply to comment #1) > Root cause: > All chart will be persisted as xml format on disk when xls saving, which is > time consuming. > > Resolution: > If the chart has not been modified, then no need to update the persist files > redundantly. It should be better that if you can add the description of how to do UT for this feature.
steps for UT: 1. functiaonality aspect open some .xls format document(with ole in it), modify the ole, then save, to see whether the content is right or not. open some .xls format document(with ole in it), modify some texts, then save, to see whether the content is right or not. 2. performance aspect open .xls document with many oles in it, do not modify ole or modify small quantities of oles, then save, to see how much time cost by saving compared with old version.
"af" committed SVN revision 1359225: "#i120168# Do not call storeOwn() when not necessary. "
Comment on attachment 78598 [details] sample Not a patch, no review necessary.
Comment on attachment 78597 [details] patch Reviewed and tested: OK
Setting status to fixed.
Suggest to put it into AOO 3.5.0 release
fixed in 4.0.0