Issue 120149 - Autoupdate display not work when paste or cut by menu
Summary: Autoupdate display not work when paste or cut by menu
Status: CLOSED FIXED
Alias: None
Product: Math
Classification: Application
Component: ui (show other issues)
Version: 3.4.0
Hardware: All All
: P3 Normal (vote)
Target Milestone: 3.4.1
Assignee: Ariel Constenla-Haile
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-02 09:44 UTC by Terry Yang
Modified: 2012-07-25 09:25 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 3.4.1_release_blocker+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Terry Yang 2012-07-02 09:44:08 UTC 
Test on AOO 3.4.1 Dev snapshot r1351960, this issue also can be repro on OO 3.3

First make autoupdate display enable.

Input a+b into the formula in Commands Window, the formula will autoupdate display in the view windows.

Select the formula in the commands windows, then go to menu "Edit->Cut".

The display windows not autoupdate. If we change something in the commands windows then the windows will autoupdate.

The same issue also repro when paste formula by menu "Edit->Paste".


If we do cut paste by short key, the windows will Autoupdate.
Comment 1 Ariel Constenla-Haile 2012-07-02 11:35:00 UTC 
The problem is that SmEditWindow flushes the changes only in the modify time handler, but not in Cut()/Copy()/Paste()/Delete(), all of which are invoked by SmViewShell::Execute when the respective slot is executed.
Comment 2 Ariel Constenla-Haile 2012-07-02 11:43:54 UTC 
Fixed in revision 1356190
Comment 3 Ariel Constenla-Haile 2012-07-02 11:46:39 UTC 
@Terry: note that AutoDisplay is broken also when Undo/Redo, independent of this fix. You may open a new bug.
Another bug: Clipboard actions are not available on the "Commands" window's context menu. You may open a new bug too.
Comment 4 Ariel Constenla-Haile 2012-07-02 11:47:52 UTC 
IMHO the fix is trivial, low risk, and a nice-to-have for 3.4.1, so requesting release blocker.
Comment 5 Terry Yang 2012-07-03 01:51:56 UTC 
Open bug 120156 for undo and redo issue.
Comment 6 Terry Yang 2012-07-03 02:08:48 UTC 
(In reply to comment #3)
> @Terry: note that AutoDisplay is broken also when Undo/Redo, independent of
> this fix. You may open a new bug.
> Another bug: Clipboard actions are not available on the "Commands" window's
> context menu. You may open a new bug too.

There is a Bug 81156 about Clipboard action are not available on "Commands" windows context menu.
Comment 7 Ariel Constenla-Haile 2012-07-03 06:11:21 UTC 
(In reply to comment #6)
> > Another bug: Clipboard actions are not available on the "Commands" window's
> > context menu. You may open a new bug too.
> 
> There is a Bug 81156 about Clipboard action are not available on "Commands"
> windows context menu.

Thanks for finding this out.
Comment 8 jsc 2012-07-09 13:29:01 UTC 
set release blocker flag for 3.4.1

@Ariel: will you merge the fix in AOO34?
Comment 9 SVN Robot 2012-07-09 14:19:20 UTC 
"arielch" committed SVN revision 1359185: "#i120149# - Merge fix from trunk into AOO34 branch"
Comment 10 Li Feng Wang 2012-07-17 08:49:04 UTC 
Verified steps:
1)Open fomular editor;
2)Input a+b into the formula in Commands Window, check the autoupdate in view window
3)Click Menu Edit->Cut, then check the autoupdate in view window
4)Click Menu Edit->Paste, then check the autoupdate in view window

Results:Pass
1)after step3, preview in view window will disapper automatically.
2)after step4, preview in view window will appear automatically.

Build:
Aoo341 branch r1359641 on Windows XP
Comment 11 Li Feng Wang 2012-07-18 09:53:59 UTC 
Verified pass on AOO trunk r1362376.
Comment 12 jsc 2012-07-25 09:25:08 UTC 
set target milestone AOO 3.4.1