Issue 120051 - [From Symphony]the text in the table turn to black from white when opening the pptx file
Summary: [From Symphony]the text in the table turn to black from white when opening th...
Status: CLOSED FIXED
Alias: None
Product: Impress
Classification: Application
Component: open-import (show other issues)
Version: 3.4.0
Hardware: PC Windows XP
: P3 Normal (vote)
Target Milestone: 4.0.0
Assignee: AOO issues mailing list
QA Contact:
URL:
Keywords:
: 120052 120053 120054 (view as issue list)
Depends on:
Blocks:
 
Reported: 2012-06-21 07:59 UTC by bjcheny
Modified: 2017-05-20 10:31 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Sample pptx has text in table (45.82 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2012-06-21 07:59 UTC, bjcheny 		no flags Details
patch for text color in table from pptx (5.88 KB, patch)
2012-06-21 09:34 UTC, bjcheny 		companycy: review?
Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description bjcheny 2012-06-21 07:59:10 UTC 
Created attachment 78419 [details]
Sample pptx has text in table

Please see attached file PPTX_43377_NoTransparency.pptx, slide 3, the text in the table turn to black from white.
Comment 1 bjcheny 2012-06-21 08:08:56 UTC 
*** Issue 120054 has been marked as a duplicate of this issue. ***
Comment 2 bjcheny 2012-06-21 08:09:24 UTC 
*** Issue 120053 has been marked as a duplicate of this issue. ***
Comment 3 bjcheny 2012-06-21 08:09:46 UTC 
*** Issue 120052 has been marked as a duplicate of this issue. ***
Comment 4 liuping 2012-06-21 08:23:15 UTC 
confirm the bug
Comment 5 bjcheny 2012-06-21 09:17:36 UTC 
1. Root Cause:
The text color in table is decided by table style.Refer to tableStyles.xml.

<a:wholeTbl>
	<a:tcTxStyle>
		<a:schemeClr val="lt1"/>
	</a:tcTxStyle>
</a:wholeTbl>

And the lt1 is from theme.xml.
<a:lt1>
	<a:sysClr val="window" lastClr="FFFFFF"/>
</a:lt1>

2. Resoltion:
In this sample, we need to get char color from tableStyles.xml and keep it to apply on text run.And char color from tableStyles.xml should have higher priority than that from master page.
Comment 6 bjcheny 2012-06-21 09:34:07 UTC 
Created attachment 78425 [details]
patch for text color in table from pptx

In this sample, the color of text in table is decided by related table style.
And this char color from table style has higher priority than that from master page.
Thus, patch involves 3 parts:
1. add lcl_getCharPropFromTblStylePart() to get char color from table style, including wholeTbl/firstRow/firstCol/...
2. pass the char color during getTextbody()->insertAt()
3. when combine the char color from table style and master page, keep color from table style if existing.
Comment 7 Armin Le Grand 2012-06-21 15:46:39 UTC 
ALG: Added code, built and checked functionality. Works as expected. Checked the code, makes sense. Review done.
Checked in as r1352577, thanks for the patch!
Comment 8 liuping 2012-08-20 06:20:25 UTC 
Verified pass on Windows7-64bit, Redhat 32bit,ubutu 10.04 Mac10.7 with AOO trunk r1374181
Comment 9 Shenfeng Liu 2012-10-09 05:40:32 UTC 
set Target Milestone to AOO 3.5.0 for PM purpose.