Issue 120033 - Include only one english dictionary
Summary: Include only one english dictionary
Status: CLOSED FIXED
Alias: None
Product: extensions
Classification: Extensions
Component: www (show other issues)
Version: AOO 3.4.0
Hardware: PC All
: P3 Normal (vote)
Target Milestone: 3.4.1
Assignee: issues@extensions
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 119272
  Show dependency tree
 
Reported: 2012-06-19 12:02 UTC by Andre
Modified: 2017-05-20 08:57 UTC (History)
5 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 3.4.1_release_blocker+


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description Andre 2012-06-19 12:02:02 UTC
At the moment there are five dictionary extensions included in the english version of OpenOffice:

dict-en.oxt
en_CA_2_0_0.oxt
dict-en-au-2008-12-15.oxt
dict-en-nz-2008-12-03.oxt
en_US.oxt

These cover different versions of the english language (CA,BT,US,NZ,AU).
This leads to two problems:
1. dict-en.oxt and dict-en-nz-2008-12-03.oxt provide the same thesaurus file and that leads to a conflict.
2. The five extensions provide four thesaurus files, three of them identical, all about 18MB large.  This wastes a lot of space.  See bug 119272 for more details on this.

Drop all these dictionaries except dict-en.oxt.
dict-en.oxt covers the variants AU, CA, GB,US, and ZA anyway.
Comment 1 Terry 2012-06-19 21:40:39 UTC
Will it still be possible for users to install the other extensions and remove the default dictionary?
Comment 2 Ariel Constenla-Haile 2012-06-19 22:11:00 UTC
(In reply to comment #1)
> Will it still be possible for users to install the other extensions and
> remove the default dictionary?

yes, this is only about the dictionaries included in the default installation. You can always install any dictionary you want.
Comment 3 jsc 2012-06-27 09:06:08 UTC
add release blocker flag for 3.4.1
Comment 4 Andre 2012-06-29 15:04:18 UTC
Updated main/extensions.lst.

SVN revision is 1355436.
Comment 5 Li Feng Wang 2012-07-10 05:30:58 UTC
Verify steps:
1)check OOo-dev 3\share\extensions\install, 
dropping all english extensions except dict-en.oxt.
may have dict-en.oxt and en_US.oxt in this directory, but only dict-en.oxt for en.*.
2)simple spell check test.
Comment 6 SVN Robot 2012-07-10 11:24:19 UTC
"af" committed SVN revision 1359603 into /branches:
#i120033# Include only dict-en.oxt as dictionary for en-US and en-GB.
Comment 7 Andre 2012-07-10 11:26:12 UTC
Merged fix into 3.4.1 branch.
Comment 8 Li Feng Wang 2012-07-17 02:28:21 UTC
Verify steps:
1)check OOo-dev 3\share\extensions\install, 
dropping all english extensions except dict-en.oxt.
2)simple spell check test.

pass on AOO341 branch r1359641
Comment 9 louqle 2012-07-17 08:16:21 UTC
on Windows XP, Win7 and Ubuntu 10.04 against build r1359641

Only one English dic when clean install Aoo 3.4.1

But there are still 5 En dictionaries when upgrade from Aoo 3.4 to 3.4.1
Comment 10 Ariel Constenla-Haile 2012-07-17 13:31:13 UTC
(In reply to comment #9)
> But there are still 5 En dictionaries when upgrade from Aoo 3.4 to 3.4.1

Upgrading from one version to another won't remove the extensions already deployed in the user installation. As far as I know, this is the expected behavior.
Comment 11 jsc 2012-07-17 14:22:49 UTC
expected is a question of definition here. It would be nice if we track which extensions would have been installed by default. A cleanup based on this info could make sense but is not trivial when we take into account that the users has already upgraded an extension. It's of course more complex and we should think about a reliable solution for the future.

The whole extension deployment stuff is fragile and complex implemented... A lot of room for improvements.

The problem here is that the thesaurus (as far as I have understand) of the extensions can conflict. Workaround for upgrade installations would be to uninstall the extension manually.
Comment 12 louqle 2012-07-18 02:34:55 UTC
I try another common scenario just now on my XP:

1. Install Aoo 3.4. There are five English dictionaries.

2. Uninstall Aoo 3.4. This will remove the installation folder in c:\program files, but the user profile under user home C:\Documents and Settings\%user%\Application Data is kept.

3. Install Aoo 3.4.1

The extensions remains: 5 English dictionaries. And the presenter console is not installed either, Which is fixed in bug 119206.

I said if clean install 3.4.1 it's correct, Here the clean install means remove the user profile in C:\Documents and Settings\%user%\Application Data.

But I think few users will do this after uninstall.
Comment 13 Li Feng Wang 2012-07-18 08:34:46 UTC
Verifed pass on AOO trunk 1362376

Suggest to arise another defect to record this kind of problem of upgrade install.  It may more complex to solve.
Comment 14 jsc 2012-07-25 09:22:22 UTC
set target milestone AOO 3.4.1