Apache OpenOffice (AOO) Bugzilla – Issue 119874
[From Symphony]The vertical text alignment of the placeholder is wrong while opening the ppt file in AOO
Last modified: 2012-12-26 08:09:34 UTC
Created attachment 78122 [details] sample file build: AOO3.4 r1327774 steps: 1. Launch AOO and open the attachment .ppt file 2. Check the text alignment of the placeholder with it in the Powerpoint Defect: The vertical text alignment of the placeholder is wrong.
I am investigating this issue.
Root cause: For the placeholder with default text, its alignment is not handled when import Solution: When import, according to text flow and text anchor, set the horizontal and vertical default text alignment. Limitation: There are still some layout import issues which will impact the verification of the fix. If the alignment is not the default alignment of the sd layout, the place holder border and default text will not be imported. The place holder will be hidden. So to verify the fix, input some words in the hidden place holder.
Created attachment 78510 [details] UT files for this defect
Created attachment 78511 [details] Patch for this issue
patch looks good and test passed.
One question regarding line 7829 bVerticalText = !bVerticalText; Is this, in this context, just a fancy way of setting bVerticalText to sal_True?
(In reply to comment #6) > One question regarding line 7829 > > bVerticalText = !bVerticalText; > > Is this, in this context, just a fancy way of setting bVerticalText to > sal_True? In the very beginning, there are some other handling for bVerticalText. So it is handled like that. When code is committed, it can be set as sal_True.
The patch fixes the vertical alignment (in the context of the document being rotated by 90 degrees) but the horizontal alignment is still wrong: the bullet point is not completely inside the text shape. A second difference to PowerPoint is that the two shapes (title and text) intersect where there is a clear gap in PowerPoint.
(In reply to comment #8) > The patch fixes the vertical alignment (in the context of the document being > rotated by 90 degrees) but the horizontal alignment is still wrong: the > bullet point is not completely inside the text shape. > > A second difference to PowerPoint is that the two shapes (title and text) > intersect where there is a clear gap in PowerPoint. Yes, really they are not fixed in my patch. But I think they are out of the scope for this issue.
Comment on attachment 78511 [details] Patch for this issue Reviewed and tested: OK. Remaining problems are unrelated.
Fixed.
"af" committed SVN revision 1361109 into branches/AOO34: #i119874# Fixed text alignment in RTL layout.
Contrary to what the SVN bot wrote, the change was committed into trunk NOT to branches/AOO34.
@Andre, Seems a part of patch(changes for this file "sd/source/filter/ppt/pptin.cxx") is lost in your commitment. Please help commit that.
"af" committed SVN revision 1365930 into trunk: #i119874# Missing part of patch.
Good catch. Done.
verified on XP SP3 and Ubuntu 12.04 against trunk build 1374181
Created attachment 79031 [details] failed on Mac 10.7
fail on Mac 10.7, reopen
This issue focus on the horizontal and vertical alignment.Vertical text showing issue will be tracked by Bug 119474. So Please close this defect because the focus issue has been fixed.
Verified on xp, Ubuntu, win7,mac,win7-64,Vista,suse,redhat, SLED 11 SP1 64 bit, the alignment is correct. Please change to resolved again then I can close it.
horizontal and vertical alignment issue has been fixed
@louqle: Please close this bug. Thanks.
close this bug according to comments 20&21