Issue 119662 - [From Symphony]<Bullets and Numbering>The numbering changed to the solid circular bullets if open the .pptx sample
Summary: [From Symphony]<Bullets and Numbering>The numbering changed to the solid circ...
Status: CLOSED DUPLICATE of issue 119907
Alias: None
Product: Impress
Classification: Application
Component: open-import (show other issues)
Version: recent-trunk
Hardware: PC Windows XP
: P3 Normal (vote)
Target Milestone: ---
Assignee: jsc
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-06-01 08:32 UTC by bjcheny
Modified: 2012-06-25 02:52 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments
Sample pptx has circle-number bullet. (34.21 KB, application/octet-stream)
2012-06-01 08:32 UTC, bjcheny
no flags Details
patch for circle-number numbering type support in pptx (1.22 KB, patch)
2012-06-04 06:19 UTC, bjcheny
no flags Details | Diff
Sample pptx has circle-number numbering type. (33.96 KB, application/octet-stream)
2012-06-04 06:22 UTC, bjcheny
no flags Details
patch for circle-number numbering type support in pptx (1.27 KB, patch)
2012-06-07 12:08 UTC, bjcheny
companycy: review?
Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description bjcheny 2012-06-01 08:32:25 UTC
Created attachment 77888 [details]
Sample pptx has circle-number bullet.

OO Version:
r1344574

Steps:
1.Launch Openoffice, open the attached .pptx sample file then check.


The numbering is not same as MS Offece 2007.
Comment 1 bjcheny 2012-06-04 06:19:31 UTC
Created attachment 77907 [details]
patch for circle-number numbering type support in pptx

Add patch for this bug.
Comment 2 bjcheny 2012-06-04 06:22:16 UTC
Created attachment 77908 [details]
Sample pptx has circle-number numbering type.
Comment 3 bjcheny 2012-06-04 06:22:46 UTC
1. Root cause:
Some numbering types aren't defined in core functions, though it's correctly imported in oox module.
2. Resolution:
Add definition in svxenum.hxx and related cases in function which handles numbering type in unonrule.cxx.
3. Test:
Pass on Xp.Will test on Linux/Mac.
4. Dll affected:
editeng.dll is affected on Xp.

Attach patch here
Comment 4 bjcheny 2012-06-07 12:08:45 UTC
Created attachment 78148 [details]
patch for circle-number numbering type support in pptx

Code change resists in editeng module.
It adds
1. definition of new NumberingType in svxenum.hxx.
2. handle of new added NumberingType in unonrule.cxx
Comment 5 jsc 2012-06-08 12:07:43 UTC
the patch doesn't apply due to the fixes in 119907. The fix for 119907 fixed this issue as well and the sample document works.

119907 integrated by revision 1348028

*** This issue has been marked as a duplicate of issue 119907 ***
Comment 6 liuping 2012-06-25 02:52:27 UTC
confirm fixing the bug on ver 1351249 in Win7 ,pass