Issue 119640 - [Dev]FetchTarballs should reference a specific revision instead of head-of-trunk
Summary: [Dev]FetchTarballs should reference a specific revision instead of head-of-trunk
Status: CLOSED FIXED
Alias: None
Product: General
Classification: Code
Component: code (show other issues)
Version: 3.4.0
Hardware: All All
: P3 Normal (vote)
Target Milestone: 3.4.1
Assignee: hdu@apache.org
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-31 12:06 UTC by hdu@apache.org
Modified: 2017-05-20 10:32 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 3.4.1_release_blocker+


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description hdu@apache.org 2012-05-31 12:06:35 UTC
Building from a source release must not depend on the latest head of trunk because that is way too fragile. In particular the line
http://svn.apache.org/repos/asf/incubator/ooo/trunk/ext_sources/
in main/ooo.lst should be replaced with the line referencing a specific revision.
Comment 1 jsc 2012-05-31 12:34:56 UTC
set release blocker flag for 3.4.1
Comment 2 hdu@apache.org 2012-05-31 12:53:13 UTC
Fixed in revision 1344688 for AOO3.4.1 and 1344692 for AOO trunk.
Comment 3 hdu@apache.org 2012-05-31 15:13:48 UTC
And as rev 1344759 since apache lucence and commons had been updated on trunk.
Comment 4 Li Feng Wang 2012-07-09 06:08:30 UTC
Can't verify from user view, add [Dev] tag.
Comment 5 Andre 2012-07-09 10:05:52 UTC
For 3.5 trunk the ooo.lst file has been replaced by external_deps.lst.  The perl scripts have changed also.  See bug 119732 for details.
Comment 6 Li Feng Wang 2012-07-20 06:06:11 UTC
I Verified "About OpenOffice.org", to check "Rev" info.

Build:
-Trunk 1362376
-Branch 1359641

Results:
-Mac: trunk and branch all have Rev info.
-Windows: branch have Rev info, but trunk have no.
-Redhat:branch have Rev info, but trunk have no.

So Reopen it.
Comment 7 Andre 2012-07-20 09:12:41 UTC
I assume the last comment was meant for another issue, it has nothing to do with this issue.

This issue can only be verified by a developer:
- Check that main/external_deps.lst has a first (non-comment, non-empty) line that says
    SVN_TRUNK=.../!svn/bc/<revision>/...
- Check that the main/bootstrap still works.
Comment 8 Andre 2012-07-20 09:13:04 UTC
I did this check on trunk and the 3.4 branch.  Both OK.