Issue 119206 - presenter console does not install on r1309668
Summary: presenter console does not install on r1309668
Status: CLOSED FIXED
Alias: None
Product: extensions
Classification: Extensions
Component: presenterconsole (show other issues)
Version: AOO 3.4.0
Hardware: All All
: P3 Normal (vote)
Target Milestone: 3.4.1
Assignee: Andre
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-09 08:11 UTC by Oliver Brinzing
Modified: 2016-04-09 09:44 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---
jsc: 3.4.1_release_blocker+


Attachments
description.xml on Linux, rev. 1327774 (2.05 KB, text/xml)
2012-04-20 11:38 UTC, Ariel Constenla-Haile
no flags Details
use generic methods for description.xml manipulation (2.62 KB, patch)
2012-04-20 15:30 UTC, hdu@apache.org
no flags Details | Diff
updated the patch to use generic methods for presenter-screen's makefile (3.16 KB, patch)
2012-04-23 12:48 UTC, hdu@apache.org
no flags Details | Diff
Check the last modification date of the directory that contains the extensions against the flag file. The directory should have a last modification date of the installation/update (3.35 KB, patch)
2012-07-20 12:37 UTC, Andre
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this issue.
Description Oliver Brinzing 2012-04-09 08:11:39 UTC
the bundled extension does not install on r1309668 win xp/vista 32 bit:

Die Extension 'Presenter Console' ist auf diesem Computer nicht lauffähig.
Comment 1 Ariel Constenla-Haile 2012-04-20 11:37:32 UTC
(In reply to comment #0)
> the bundled extension does not install on r1309668 win xp/vista 32 bit:
> 
> Die Extension 'Presenter Console' ist auf diesem Computer nicht lauffähig.

@brinzing: can you unzip the extension and look at the description.xml?
On Linux the extension is under /opt/openoffice.org3/share/extensions/install/presenter-screen.oxt

On Linux, the description.xml has a placeholder that has not been replaced during building it:

  <identifier value="com.sun.PresenterScreen-UPDATED_PLATFORM" />
  <platform value="UPDATED_PLATFORM" />

With this value on platform the extension will never be installed.
Comment 2 Ariel Constenla-Haile 2012-04-20 11:38:56 UTC
Created attachment 77474 [details]
description.xml on Linux, rev. 1327774
Comment 3 Ariel Constenla-Haile 2012-04-20 11:57:45 UTC
Revision 1309347 removed code replacing that placeholder:

$(TYPE) $(DESCRIPTION_TMP) | sed s/UPDATED_PLATFORM/$(PLATFORMID)/ > $@

http://svn.apache.org/viewvc/incubator/ooo/trunk/main/sdext/source/presenter/makefile.mk?r1=1229815&r2=1309347&diff_format=h#l376
Comment 4 hdu@apache.org 2012-04-20 12:55:29 UTC
Good catch. Rather than reverting the non-license related part of the patch maybe using the generic platformid replacement functionality in main/solenv/inc/extension_post.mk is a better way though. The configuration space is so big that the many unique paths taken severely impacted maintainability, so we should streamline them if possible.
Comment 5 Ariel Constenla-Haile 2012-04-20 13:24:50 UTC
(In reply to comment #4)
> Good catch. Rather than reverting the non-license related part of the patch
> maybe using the generic platformid replacement functionality in
> main/solenv/inc/extension_post.mk is a better way though. 

yes, sdext/source/minimizer/makefile.mk follows this approach with UPDATED_SUPPORTED_PLATFORM and UPDATED_IDENTIFIER in sdext/source/minimizer/description.xml
Comment 6 Oliver Brinzing 2012-04-20 13:41:26 UTC
> can you unzip the extension and look at the description.xml?
> <identifier value="com.sun.PresenterScreen-UPDATED_PLATFORM" />
> <platform value="UPDATED_PLATFORM" />

yes, same problem on win
Comment 7 hdu@apache.org 2012-04-20 15:30:41 UTC
Created attachment 77477 [details]
use generic methods for description.xml manipulation
Comment 8 hdu@apache.org 2012-04-23 12:48:34 UTC
Created attachment 77482 [details]
updated the patch to use generic methods for presenter-screen's makefile
Comment 9 hdu@apache.org 2012-05-03 13:56:58 UTC
Applied the fix to use generic extension_pre / extension_post helpers for making presenter console as revision 1333462.
Comment 10 jsc 2012-05-31 14:54:30 UTC
set release blocker flag for 3.4.1
Comment 11 hdu@apache.org 2012-06-07 08:47:54 UTC
Also applied as 1347529 for AOO 3.4.1
Comment 12 louqle 2012-06-19 06:06:15 UTC
I tried to install the extension manually on trunk build r1350879, it says the extension doesn't support versions greater than "Apache OpenOffice 3.2"...But I thought the first Apache build is Aoo 3.4, isn't it?
Comment 13 Ariel Constenla-Haile 2012-06-19 06:21:30 UTC
(In reply to comment #12)
> I tried to install the extension manually on trunk build r1350879, it says
> the extension doesn't support versions greater than "Apache OpenOffice
> 3.2"...But I thought the first Apache build is Aoo 3.4, isn't it?

Where did you get that extension? From the Extensions Repository? http://extensions.openoffice.org/en/project/presenter-screen

That extension cannot be installed in AOO 3.4.0, you are right. But the issue here is with the extension bundled *with* AOO.
Comment 14 louqle 2012-06-19 06:44:20 UTC
(In reply to comment #13)
> (In reply to comment #12)
> > I tried to install the extension manually on trunk build r1350879, it says
> > the extension doesn't support versions greater than "Apache OpenOffice
> > 3.2"...But I thought the first Apache build is Aoo 3.4, isn't it?
> 
> Where did you get that extension? From the Extensions Repository?
> http://extensions.openoffice.org/en/project/presenter-screen

Yes, I got from here

> 
> That extension cannot be installed in AOO 3.4.0, you are right. But the
> issue here is with the extension bundled *with* AOO.

Thank you, I noticed the "bundled". But I remembered no "external" resource could be bundled with Aoo, and seems the dictionaries "bundled" are downloaded from website during installation. I thought they are downloaded from the extension website, and maybe this presenten console extension is the same. So I download it from the link above and tried.

Then, where are the "bundled" extension located? in source code? or downloaded from somewhere? and, where?
Comment 15 Ariel Constenla-Haile 2012-06-19 09:43:55 UTC
(In reply to comment #14)
> Thank you, I noticed the "bundled". But I remembered no "external" resource
> could be bundled with Aoo, and seems the dictionaries "bundled" are
> downloaded from website during installation. I thought they are downloaded
> from the extension website, and maybe this presenten console extension is
> the same. So I download it from the link above and tried.
> 
> Then, where are the "bundled" extension located? in source code? or
> downloaded from somewhere? and, where?

The problem with the dictionaries is their license, but the Presenter Console and the Presentation Minimizer are released under the Apache License, there is no problem here, we build them and include then in the release as bundled extensions (the fact they are extensions is just a matter of "design").

- bundled extensions are located on /opt/openoffice.org3/share/extensions/install
- dictionaries are downloaded at build time and packaged as bundled extensions
- the Presenter Console and the Presentation Minimizer are built with the rest of the source code; they are part of the source code, and released under ALv2; they are packaged as bundled extensions
Comment 16 louqle 2012-07-02 03:00:49 UTC
Ariel, Thanks for your detailed explaination. 

I verified on Windows 7 32-bit, XP, Linux redhat 6, suse 11 and Ubuntu 10.04 against dev snapshot build 1351960, the extension is installed together with Aoo.

Change the stauts to verified.

(In reply to comment #15)
> (In reply to comment #14)
> > Thank you, I noticed the "bundled". But I remembered no "external" resource
> > could be bundled with Aoo, and seems the dictionaries "bundled" are
> > downloaded from website during installation. I thought they are downloaded
> > from the extension website, and maybe this presenten console extension is
> > the same. So I download it from the link above and tried.
> > 
> > Then, where are the "bundled" extension located? in source code? or
> > downloaded from somewhere? and, where?
> 
> The problem with the dictionaries is their license, but the Presenter
> Console and the Presentation Minimizer are released under the Apache
> License, there is no problem here, we build them and include then in the
> release as bundled extensions (the fact they are extensions is just a matter
> of "design").
> 
> - bundled extensions are located on
> /opt/openoffice.org3/share/extensions/install
> - dictionaries are downloaded at build time and packaged as bundled
> extensions
> - the Presenter Console and the Presentation Minimizer are built with the
> rest of the source code; they are part of the source code, and released
> under ALv2; they are packaged as bundled extensions
Comment 17 Li Feng Wang 2012-07-09 02:32:50 UTC
Presenter console can be installed on WindowsXP with trunk r1351712
Comment 18 louqle 2012-07-17 07:31:53 UTC
reopen this since on Win7/XP when upgrade from Aoo 3.4 to 3.4.1, the Presenter console is not installed
Comment 19 louqle 2012-07-18 02:30:24 UTC
(In reply to comment #18)
> reopen this since on Win7/XP when upgrade from Aoo 3.4 to 3.4.1, the
> Presenter console is not installed

Add a new scenario:
1. Install Aoo 3.4. There are five English dictionaries.

2. Uninstall Aoo 3.4. This will remove the installation folder in c:\program files, but the user profile under user home C:\Documents and Settings\%user%\Application Data is kept.

3. Install Aoo 3.4.1

the extension is not installed.

But I can install it manually.
Comment 20 Andre 2012-07-20 12:32:48 UTC
Taking over.

One part of the problem is that the test fails that checks whether any extensions have to be installed.  This test takes compares the last modification dates of the extensions against that of a marker file.  If the marker file has been modified recently (for example because a presentation has been installed manually) then it is possible that the extensions have been built more recently (the date of building the extensions count, not the date on which the office is installed or updated.)
Comment 21 Andre 2012-07-20 12:37:15 UTC
Created attachment 78695 [details]
Check the last modification date of the directory that contains the extensions against the flag file.  The directory should have a last modification date of the installation/update

First part of a fix.  With this fix the presenter console is installed (good news) but hangs when in first office run (bad news).  No hang when started from the second run on.

Please note, that I had to modify the patch manually to remove some unrelated changes: it may not apply cleanly.
Comment 22 Andre 2012-07-20 15:51:56 UTC
The hanging presenter console is an unrelated problem.  I will create a new issue for that.  Just so much: on first start the presenter extension runs in a second process.  It tries to communicate with the office in the first process from two threads simultaneously => deadlock in cppu.)
Comment 23 Andre 2012-07-21 09:25:26 UTC
Created bug 120338 for the deadlocking extension.
Comment 24 SVN Robot 2012-07-23 09:30:34 UTC
"af" committed SVN revision 1364554 into trunk:
#i119206# Fixed up-to-date check of bundled extensions.
Comment 25 SVN Robot 2012-07-23 09:40:55 UTC
"af" committed SVN revision 1364556 into branches/AOO34:
#i119206# Fixed up-to-date check of bundled extensions.
Comment 26 Andre 2012-07-23 09:45:14 UTC
Fixed on trunk and the 3.4 branch.
Comment 27 Marcus 2016-04-09 09:44:22 UTC
fixed in 3.4.1