Apache OpenOffice (AOO) Bugzilla – Issue 119206
presenter console does not install on r1309668
Last modified: 2016-04-09 09:44:22 UTC
the bundled extension does not install on r1309668 win xp/vista 32 bit: Die Extension 'Presenter Console' ist auf diesem Computer nicht lauffähig.
(In reply to comment #0) > the bundled extension does not install on r1309668 win xp/vista 32 bit: > > Die Extension 'Presenter Console' ist auf diesem Computer nicht lauffähig. @brinzing: can you unzip the extension and look at the description.xml? On Linux the extension is under /opt/openoffice.org3/share/extensions/install/presenter-screen.oxt On Linux, the description.xml has a placeholder that has not been replaced during building it: <identifier value="com.sun.PresenterScreen-UPDATED_PLATFORM" /> <platform value="UPDATED_PLATFORM" /> With this value on platform the extension will never be installed.
Created attachment 77474 [details] description.xml on Linux, rev. 1327774
Revision 1309347 removed code replacing that placeholder: $(TYPE) $(DESCRIPTION_TMP) | sed s/UPDATED_PLATFORM/$(PLATFORMID)/ > $@ http://svn.apache.org/viewvc/incubator/ooo/trunk/main/sdext/source/presenter/makefile.mk?r1=1229815&r2=1309347&diff_format=h#l376
Good catch. Rather than reverting the non-license related part of the patch maybe using the generic platformid replacement functionality in main/solenv/inc/extension_post.mk is a better way though. The configuration space is so big that the many unique paths taken severely impacted maintainability, so we should streamline them if possible.
(In reply to comment #4) > Good catch. Rather than reverting the non-license related part of the patch > maybe using the generic platformid replacement functionality in > main/solenv/inc/extension_post.mk is a better way though. yes, sdext/source/minimizer/makefile.mk follows this approach with UPDATED_SUPPORTED_PLATFORM and UPDATED_IDENTIFIER in sdext/source/minimizer/description.xml
> can you unzip the extension and look at the description.xml? > <identifier value="com.sun.PresenterScreen-UPDATED_PLATFORM" /> > <platform value="UPDATED_PLATFORM" /> yes, same problem on win
Created attachment 77477 [details] use generic methods for description.xml manipulation
Created attachment 77482 [details] updated the patch to use generic methods for presenter-screen's makefile
Applied the fix to use generic extension_pre / extension_post helpers for making presenter console as revision 1333462.
set release blocker flag for 3.4.1
Also applied as 1347529 for AOO 3.4.1
I tried to install the extension manually on trunk build r1350879, it says the extension doesn't support versions greater than "Apache OpenOffice 3.2"...But I thought the first Apache build is Aoo 3.4, isn't it?
(In reply to comment #12) > I tried to install the extension manually on trunk build r1350879, it says > the extension doesn't support versions greater than "Apache OpenOffice > 3.2"...But I thought the first Apache build is Aoo 3.4, isn't it? Where did you get that extension? From the Extensions Repository? http://extensions.openoffice.org/en/project/presenter-screen That extension cannot be installed in AOO 3.4.0, you are right. But the issue here is with the extension bundled *with* AOO.
(In reply to comment #13) > (In reply to comment #12) > > I tried to install the extension manually on trunk build r1350879, it says > > the extension doesn't support versions greater than "Apache OpenOffice > > 3.2"...But I thought the first Apache build is Aoo 3.4, isn't it? > > Where did you get that extension? From the Extensions Repository? > http://extensions.openoffice.org/en/project/presenter-screen Yes, I got from here > > That extension cannot be installed in AOO 3.4.0, you are right. But the > issue here is with the extension bundled *with* AOO. Thank you, I noticed the "bundled". But I remembered no "external" resource could be bundled with Aoo, and seems the dictionaries "bundled" are downloaded from website during installation. I thought they are downloaded from the extension website, and maybe this presenten console extension is the same. So I download it from the link above and tried. Then, where are the "bundled" extension located? in source code? or downloaded from somewhere? and, where?
(In reply to comment #14) > Thank you, I noticed the "bundled". But I remembered no "external" resource > could be bundled with Aoo, and seems the dictionaries "bundled" are > downloaded from website during installation. I thought they are downloaded > from the extension website, and maybe this presenten console extension is > the same. So I download it from the link above and tried. > > Then, where are the "bundled" extension located? in source code? or > downloaded from somewhere? and, where? The problem with the dictionaries is their license, but the Presenter Console and the Presentation Minimizer are released under the Apache License, there is no problem here, we build them and include then in the release as bundled extensions (the fact they are extensions is just a matter of "design"). - bundled extensions are located on /opt/openoffice.org3/share/extensions/install - dictionaries are downloaded at build time and packaged as bundled extensions - the Presenter Console and the Presentation Minimizer are built with the rest of the source code; they are part of the source code, and released under ALv2; they are packaged as bundled extensions
Ariel, Thanks for your detailed explaination. I verified on Windows 7 32-bit, XP, Linux redhat 6, suse 11 and Ubuntu 10.04 against dev snapshot build 1351960, the extension is installed together with Aoo. Change the stauts to verified. (In reply to comment #15) > (In reply to comment #14) > > Thank you, I noticed the "bundled". But I remembered no "external" resource > > could be bundled with Aoo, and seems the dictionaries "bundled" are > > downloaded from website during installation. I thought they are downloaded > > from the extension website, and maybe this presenten console extension is > > the same. So I download it from the link above and tried. > > > > Then, where are the "bundled" extension located? in source code? or > > downloaded from somewhere? and, where? > > The problem with the dictionaries is their license, but the Presenter > Console and the Presentation Minimizer are released under the Apache > License, there is no problem here, we build them and include then in the > release as bundled extensions (the fact they are extensions is just a matter > of "design"). > > - bundled extensions are located on > /opt/openoffice.org3/share/extensions/install > - dictionaries are downloaded at build time and packaged as bundled > extensions > - the Presenter Console and the Presentation Minimizer are built with the > rest of the source code; they are part of the source code, and released > under ALv2; they are packaged as bundled extensions
Presenter console can be installed on WindowsXP with trunk r1351712
reopen this since on Win7/XP when upgrade from Aoo 3.4 to 3.4.1, the Presenter console is not installed
(In reply to comment #18) > reopen this since on Win7/XP when upgrade from Aoo 3.4 to 3.4.1, the > Presenter console is not installed Add a new scenario: 1. Install Aoo 3.4. There are five English dictionaries. 2. Uninstall Aoo 3.4. This will remove the installation folder in c:\program files, but the user profile under user home C:\Documents and Settings\%user%\Application Data is kept. 3. Install Aoo 3.4.1 the extension is not installed. But I can install it manually.
Taking over. One part of the problem is that the test fails that checks whether any extensions have to be installed. This test takes compares the last modification dates of the extensions against that of a marker file. If the marker file has been modified recently (for example because a presentation has been installed manually) then it is possible that the extensions have been built more recently (the date of building the extensions count, not the date on which the office is installed or updated.)
Created attachment 78695 [details] Check the last modification date of the directory that contains the extensions against the flag file. The directory should have a last modification date of the installation/update First part of a fix. With this fix the presenter console is installed (good news) but hangs when in first office run (bad news). No hang when started from the second run on. Please note, that I had to modify the patch manually to remove some unrelated changes: it may not apply cleanly.
The hanging presenter console is an unrelated problem. I will create a new issue for that. Just so much: on first start the presenter extension runs in a second process. It tries to communicate with the office in the first process from two threads simultaneously => deadlock in cppu.)
Created bug 120338 for the deadlocking extension.
"af" committed SVN revision 1364554 into trunk: #i119206# Fixed up-to-date check of bundled extensions.
"af" committed SVN revision 1364556 into branches/AOO34: #i119206# Fixed up-to-date check of bundled extensions.
Fixed on trunk and the 3.4 branch.
fixed in 3.4.1