Issue 118828 - Add new color picker to Apache OpenOffice
Summary: Add new color picker to Apache OpenOffice
Status: CLOSED FIXED
Alias: None
Product: Draw
Classification: Application
Component: ui (show other issues)
Version: 3.4.0 Beta (OOo)
Hardware: PC Windows 7
: P5 (lowest) Normal (vote)
Target Milestone: ---
Assignee: Armin Le Grand
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-23 16:37 UTC by Armin Le Grand
Modified: 2012-09-06 02:57 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Diff to apply to get the colorpicker (131.02 KB, patch)
2012-01-25 09:40 UTC, Armin Le Grand 		no flags Details | Diff
The needed image (218 bytes, image/png)
2012-01-25 09:41 UTC, Armin Le Grand 		no flags Details
Version working on mac and win (132.87 KB, patch)
2012-01-26 11:07 UTC, Armin Le Grand 		no flags Details | Diff
Visualisation of old and new ColorPicker (82.00 KB, application/pdf)
2012-01-27 09:31 UTC, Armin Le Grand 		no flags Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Armin Le Grand 2012-01-23 16:37:02 UTC 
ALG: I asked Christian Lippka who wrote a nice new color picker for the office. He already doneted it to LO, but he gave his okay to add it to Apache license, too. Investigating his patches from an old, not integrated CWS...
Comment 1 Armin Le Grand 2012-01-23 16:52:15 UTC 
ALG: Taking over...
Comment 2 Armin Le Grand 2012-01-25 09:39:40 UTC 
ALG: Added, adapted, working on Win. Tested on Mac, for some reason the colorpicker works not reliable except RGB selected. Adding current diff and needed imagefile as attachment.
Comment 3 Armin Le Grand 2012-01-25 09:40:33 UTC 
Created attachment 77163 [details]
Diff to apply to get the colorpicker

Diff to apply to get the colorpicker
Comment 4 Armin Le Grand 2012-01-25 09:41:38 UTC 
Created attachment 77164 [details]
The needed image

Image is for location main/default_images/res/colorslider.png
Comment 5 Armin Le Grand 2012-01-26 11:02:27 UTC 
ALG: Found problem on mac, static bool equals( double a, double b ) does not work using std::numeric_limits<double>::epsilon(), replaced with basegfx::fTools::equal and basegfx::fTools::equalZero. Works well.
Comment 6 Armin Le Grand 2012-01-26 11:07:51 UTC 
Created attachment 77170 [details]
Version working on mac and win

Version working on mac and win
Comment 7 Armin Le Grand 2012-01-26 15:26:01 UTC 
ALG: Building linux version to ensure functionality there...
Comment 8 Armin Le Grand 2012-01-27 09:26:57 UTC 
ALG: Linux build done, dialog is working properly. Ready to apply, though.
Comment 9 Armin Le Grand 2012-01-27 09:31:34 UTC 
Created attachment 77172 [details]
Visualisation of old and new ColorPicker
Comment 10 Armin Le Grand 2012-02-02 17:27:38 UTC 
ALG: Okay, about a week on the dev list, no complaints. Committing. Kudos go to Christian Lippka for providing it under Apache license!
Comment 11 Oliver-Rainer Wittmann 2012-06-13 12:22:17 UTC 
getting rid of value "enhancement" for field "severity".
For enhancement the field "issue type" shall be used.
Comment 12 louqle 2012-09-06 02:57:46 UTC 
this is infact a feature and had been committed. Close