Issue 118613 - IP clearance: Remove KDE Crystal image icons
Summary: IP clearance: Remove KDE Crystal image icons
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: external prerequisites (show other issues)
Version: 4.0.0-dev
Hardware: PC All
: P5 (lowest) Blocker (vote)
Target Milestone: ---
Assignee: stx123
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 118566
  Show dependency tree
 
Reported: 2011-11-17 22:33 UTC by Pedro Giffuni
Modified: 2013-02-21 23:22 UTC (History)
3 users (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Remove crystal icons theme (27.99 KB, patch)
2011-11-25 03:03 UTC, Pedro Giffuni 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description Pedro Giffuni 2011-11-17 22:33:09 UTC 
The icon theme at:
external_images/ooo_crystal_images-1.tar.gz
was introduced by Issue 60434 and while it is claimed there that this
is "partially JCA covered", the thirdpartylicenses.html file
makes it clear that this si copyleft (LGPL).

I made an attempt to remove this icon set and have us use
Tango for KDE in r1203215 but this resulted breaking the world
in the packimages module:

> dmake:  Error: --
> `../unxmacxi.pro/misc/hicontrast.flag' not found, and can't
> be made
> ERROR: error 65280 occurred while making
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/packimages/pack

It was probably something easy to solve but for now I preferred
to revert it. I will be working on a less invasive patch and
I will post it here for future review.
Comment 1 Andre 2011-11-24 10:01:37 UTC 
Hi Pedro,

how is your work coming along?
Can I help?
Comment 2 Pedro Giffuni 2011-11-24 10:42:10 UTC 
(In reply to comment #1)
> Hi Pedro,
> 
> how is your work coming along?
> Can I help?

I have been a little busy but I will have a patch for this today.

Thanks!
Comment 3 Pedro Giffuni 2011-11-25 03:03:44 UTC 
Created attachment 77045 [details]
Remove crystal icons theme

I found where I failed in my first attempt.

This should work but is still untested so I review it further.
Comment 4 Pedro Giffuni 2011-11-25 16:10:43 UTC 
svn commit -m "i118613 - IP clearance: Remove LGPLd KDE Crystal image icons."
Sending        binfilter/bf_svtools/source/config/svt_miscopt.cxx
Sending        binfilter/inc/bf_svtools/imgdef.hxx
Sending        cui/source/options/optgdlg.src
Deleting       external_images
Sending        packimages/pack/makefile.mk
Sending        readlicense_oo/html/THIRDPARTYLICENSEREADME.html
Sending        scp2/source/ooo/file_ooo.scp
Sending        scp2/source/ooo/module_hidden_ooo.scp
Sending        solenv/config/sooo340.ini
Sending        vcl/inc/toolbox.h
Sending        vcl/inc/vcl/settings.hxx
Sending        vcl/source/app/settings.cxx
Sending        vcl/source/window/toolbox2.cxx
Transmitting file data ............
Committed revision 1206244.
Comment 5 hdu@apache.org 2012-01-30 13:37:00 UTC 
Closing resolved issue.